address PR feedback: typed errors, move request model, add LICENSE, cleanup comments

Author: YunchuWang

packages/durabletask-js-export-history/LICENSE

@@ -0,0 +1,21 @@
+    MIT License
+
+    Copyright (c) Microsoft Corporation.
+
+    Permission is hereby granted, free of charge, to any person obtaining a copy
+    of this software and associated documentation files (the "Software"), to deal
+    in the Software without restriction, including without limitation the rights
+    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+    copies of the Software, and to permit persons to whom the Software is
+    furnished to do so, subject to the following conditions:
+
+    The above copyright notice and this permission notice shall be included in all
+    copies or substantial portions of the Software.
+
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+    SOFTWARE

packages/durabletask-js-export-history/src/activities/export-instance-history-activity.ts

@@ -6,6 +6,7 @@ import { gzipSync } from "zlib";
 import { BlobServiceClient } from "@azure/storage-blob";
 import { ActivityContext, HistoryEvent, OrchestrationStatus, TaskHubGrpcClient } from "@microsoft/durabletask-js";
 import { ExportDestination, ExportFormat, ExportFormatKind, ExportHistoryStorageOptions } from "../models";
+import { ExportJobClientValidationError } from "../errors";
 
 /**
  * Export request for one orchestration instance.
@@ -117,16 +118,16 @@ export function createExportInstanceHistoryActivity(
     input: ExportRequest,
   ): Promise<ExportResult> {
     if (!input) {
-      throw new Error("input is required");
+      throw new ExportJobClientValidationError("input is required", "input");
     }
     if (!input.instanceId) {
-      throw new Error("instanceId is required");
+      throw new ExportJobClientValidationError("instanceId is required", "instanceId");
     }
     if (!input.destination) {
-      throw new Error("destination is required");
+      throw new ExportJobClientValidationError("destination is required", "destination");
     }
     if (!input.format) {
-      throw new Error("format is required");
+      throw new ExportJobClientValidationError("format is required", "format");
     }
 
     const instanceId = input.instanceId;

packages/durabletask-js-export-history/src/activities/list-terminal-instances-activity.ts

@@ -3,6 +3,7 @@
 
 import { ActivityContext, OrchestrationStatus, TaskHubGrpcClient } from "@microsoft/durabletask-js";
 import { ExportCheckpoint } from "../models";
+import { ExportJobClientValidationError } from "../errors";
 
 /**
  * Input for listing terminal instances activity.
@@ -62,7 +63,7 @@ export function createListTerminalInstancesActivity(client: TaskHubGrpcClient) {
     input: ListTerminalInstancesRequest,
   ): Promise<InstancePage> {
     if (!input) {
-      throw new Error("input is required");
+      throw new ExportJobClientValidationError("input is required", "input");
     }
 
     // Dates arrive as ISO strings after JSON round-tripping through orchestration input.

packages/durabletask-js-export-history/src/client/export-history-client.ts

@@ -17,6 +17,7 @@ import {
   ExportJobState,
   ExportDestination,
   ExportHistoryStorageOptions,
+  ExportJobOperationRequest,
   DEFAULT_EXPORT_JOB_QUERY_PAGE_SIZE,
 } from "../models";
 import {
@@ -25,7 +26,6 @@ import {
   getOrchestratorInstanceId,
 } from "../constants";
 import { ExportJobNotFoundError } from "../errors";
-import { ExportJobOperationRequest } from "../orchestrators/execute-export-job-operation-orchestrator";
 
 /**
  * Client for managing export history jobs.
@@ -188,9 +188,6 @@ export class ExportHistoryJobClient {
         `Failed to create export job '${this.jobId}': ${state?.failureDetails?.message ?? "Unknown error"}`,
       );
     }
-
-    // The entity's Create operation signals Run, which schedules the export orchestrator.
-    // No need to schedule the orchestrator from the client.
   }
 
   /**

packages/durabletask-js-export-history/src/index.ts

@@ -26,6 +26,7 @@ export {
   ExportJobStatus,
   isValidTransition,
   ExportMode,
+  ExportJobOperationRequest,
 } from "./models";
 
 // Entity
@@ -45,10 +46,7 @@ export {
 
 // Orchestrators
 export { exportJobOrchestrator } from "./orchestrators/export-job-orchestrator";
-export {
-  executeExportJobOperationOrchestrator,
-  ExportJobOperationRequest,
-} from "./orchestrators/execute-export-job-operation-orchestrator";
+export { executeExportJobOperationOrchestrator } from "./orchestrators/execute-export-job-operation-orchestrator";
 
 // Client
 export { ExportHistoryClient, ExportHistoryJobClient } from "./client/export-history-client";

packages/durabletask-js-export-history/src/models/export-job-operation-request.ts

@@ -0,0 +1,27 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+/**
+ * Request to execute an operation on an ExportJob entity via orchestration.
+ *
+ * Note: `entityId` is serialized as a string (e.g. "@exportjob@my-key") rather than
+ * an EntityInstanceId object to ensure it survives JSON round-tripping through
+ * orchestration input serialization.
+ */
+export interface ExportJobOperationRequest {
+  /**
+   * The entity instance ID in string form (e.g. "@exportjob@my-key").
+   * Use EntityInstanceId.toString() to produce this value.
+   */
+  readonly entityId: string;
+
+  /**
+   * The operation name to invoke on the entity.
+   */
+  readonly operationName: string;
+
+  /**
+   * Optional input for the operation.
+   */
+  readonly input?: unknown;
+}

packages/durabletask-js-export-history/src/models/index.ts

@@ -23,3 +23,4 @@ export { ExportJobState, createInitialExportJobState } from "./export-job-state"
 export { ExportJobStatus } from "./export-job-status";
 export { isValidTransition } from "./export-job-transitions";
 export { ExportMode } from "./export-mode";
+export { ExportJobOperationRequest } from "./export-job-operation-request";

packages/durabletask-js-export-history/src/orchestrators/execute-export-job-operation-orchestrator.ts

@@ -2,31 +2,7 @@
 // Licensed under the MIT License.
 
 import { OrchestrationContext, TOrchestrator, EntityInstanceId } from "@microsoft/durabletask-js";
-
-/**
- * Request to execute an operation on an ExportJob entity via orchestration.
- *
- * Note: `entityId` is serialized as a string (e.g. "@exportjob@my-key") rather than
- * an EntityInstanceId object to ensure it survives JSON round-tripping through
- * orchestration input serialization.
- */
-export interface ExportJobOperationRequest {
-  /**
-   * The entity instance ID in string form (e.g. "@exportjob@my-key").
-   * Use EntityInstanceId.toString() to produce this value.
-   */
-  readonly entityId: string;
-
-  /**
-   * The operation name to invoke on the entity.
-   */
-  readonly operationName: string;
-
-  /**
-   * Optional input for the operation.
-   */
-  readonly input?: unknown;
-}
+import { ExportJobOperationRequest } from "../models";
 
 /**
  * A simple orchestrator that routes an operation to the export job entity.