Skip to content

Commit 6148b02

Browse files
committed
fix: rename variable for clarity and improve test readability
1 parent cd8468f commit 6148b02

File tree

2 files changed

+18
-3
lines changed

2 files changed

+18
-3
lines changed

package-lock.json

Lines changed: 14 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/durabletask-js/test/parent-orchestration-instance.spec.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,12 @@ describe("Parent Orchestration Instance", () => {
9292
it("should preserve parent info during replay", async () => {
9393
let capturedParentDuringReplay: ParentOrchestrationInstance | undefined;
9494
let capturedParentAfterReplay: ParentOrchestrationInstance | undefined;
95-
let replayState = true;
95+
let _replayState = true;
9696

9797
const orchestrator: TOrchestrator = async function* (ctx: OrchestrationContext): any {
9898
if (ctx.isReplaying) {
9999
capturedParentDuringReplay = ctx.parent;
100-
replayState = ctx.isReplaying;
100+
_replayState = ctx.isReplaying;
101101
}
102102

103103
// Create a timer to force replay
@@ -169,6 +169,7 @@ describe("Parent Orchestration Instance", () => {
169169
it("should make parent info available in generator orchestrations", async () => {
170170
let capturedParent: ParentOrchestrationInstance | undefined;
171171

172+
// eslint-disable-next-line require-yield
172173
const orchestrator: TOrchestrator = async function* (ctx: OrchestrationContext): any {
173174
capturedParent = ctx.parent;
174175
return "done";
@@ -187,7 +188,7 @@ describe("Parent Orchestration Instance", () => {
187188
];
188189

189190
const executor = new OrchestrationExecutor(registry, testLogger);
190-
const result = await executor.execute(TEST_INSTANCE_ID, [], newEvents);
191+
await executor.execute(TEST_INSTANCE_ID, [], newEvents);
191192

192193
// Verify parent instance info is accessible in generator functions
193194
expect(capturedParent).toBeDefined();

0 commit comments

Comments
 (0)