feedback

Author: YunchuWang

packages/durabletask-js-export-history/src/client/export-history-client.ts

@@ -211,13 +211,13 @@ export class ExportHistoryJobClient {
 
   /**
    * Deletes the export job.
-   * Signals entity deletion via operation orchestrator (fire-and-forget, aligned with .NET),
+   * Schedules entity deletion via operation orchestrator (does not wait for completion, aligned with .NET),
    * then terminates and purges the linked export orchestration.
    */
   async delete(): Promise<void> {
     const orchestrationInstanceId = getOrchestratorInstanceId(this.jobId);
 
-    // First, delete the entity (fire-and-forget — does not wait for the operation orchestrator)
+    // Schedule entity deletion (does not wait for the operation orchestrator to complete)
     const request: ExportJobOperationRequest = {
       entityId: this.entityId.toString(),
       operationName: "delete",

packages/durabletask-js-export-history/src/entity/export-job.ts

@@ -152,9 +152,10 @@ export class ExportJob extends TaskEntity<ExportJobState> {
     this.state.lastCheckpointTime = now;
     this.state.lastModifiedAt = now;
 
-    // If there are failures and checkpoint is null (batch failed), mark job as failed
+    // Record failures for diagnostics but do NOT update job status here.
+    // Failure status transitions are handled exclusively by markAsFailed(),
+    // which is called by the orchestrator after retry exhaustion.
     if (!request.checkpoint && request.failures && request.failures.length > 0) {
-      this.state.status = ExportJobStatus.Failed;
       const failureSummary = request.failures
         .map((f) => `${f.instanceId}: ${f.reason}`)
         .join("; ");

packages/durabletask-js-export-history/src/models/export-job-creation-options.ts

@@ -147,6 +147,15 @@ export function createExportJobCreationOptions(
       ? options.runtimeStatus
       : terminalStatuses;
 
+  // Validate maxParallelExports range
+  const validatedMaxParallelExports = options.maxParallelExports ?? DEFAULT_MAX_PARALLEL_EXPORTS;
+  if (validatedMaxParallelExports <= 0) {
+    throw new ExportJobClientValidationError(
+      "MaxParallelExports must be greater than 0.",
+      "maxParallelExports",
+    );
+  }
+
   return {
     jobId,
     mode,
@@ -156,6 +165,6 @@ export function createExportJobCreationOptions(
     destination: options.destination,
     format: options.format ?? createExportFormat(ExportFormatKind.Jsonl),
     maxInstancesPerBatch: options.maxInstancesPerBatch ?? DEFAULT_MAX_INSTANCES_PER_BATCH,
-    maxParallelExports: options.maxParallelExports ?? DEFAULT_MAX_PARALLEL_EXPORTS,
+    maxParallelExports: validatedMaxParallelExports,
   };
 }

packages/durabletask-js-export-history/test/models.spec.ts

@@ -198,6 +198,27 @@ describe("Models", () => {
       ).toThrow("MaxInstancesPerBatch");
     });
 
+    it("should throw when maxParallelExports is zero or negative", () => {
+      expect(() =>
+        createExportJobCreationOptions({
+          jobId: "test-job",
+          completedTimeFrom: new Date("2024-01-01"),
+          completedTimeTo: new Date("2024-06-01"),
+          mode: ExportMode.Batch,
+          maxParallelExports: 0,
+        }),
+      ).toThrow("MaxParallelExports");
+      expect(() =>
+        createExportJobCreationOptions({
+          jobId: "test-job",
+          completedTimeFrom: new Date("2024-01-01"),
+          completedTimeTo: new Date("2024-06-01"),
+          mode: ExportMode.Batch,
+          maxParallelExports: -1,
+        }),
+      ).toThrow("MaxParallelExports");
+    });
+
     it("should throw when runtimeStatus contains non-terminal status", () => {
       expect(() =>
         createExportJobCreationOptions({

test/e2e-azuremanaged/export-history.spec.ts

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
 /**