Skip to content

Commit 9bdc0b2

Browse files
authored
Enforce Azure Managed e2e tests in daily-code-review agent (#139)
1 parent 647e363 commit 9bdc0b2

1 file changed

Lines changed: 11 additions & 3 deletions

File tree

.github/agents/daily-code-review.agent.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,12 +151,15 @@ Example: `copilot-finds/bug/fix-unhandled-promise-rejection`
151151
- Would have caught the bug (for bug fixes)
152152
- Cover the previously uncovered path (for missing tests)
153153
- Verify the improvement works (for improvements)
154-
- **If the change affects orchestration, activity, entity, or client/worker behavior:**
155-
Add **Azure Managed e2e test(s)** in `test/e2e-azuremanaged/` as well. Follow the
156-
existing patterns there (uses `DurableTaskAzureManagedClientBuilder` /
154+
- **Azure Managed e2e tests (MANDATORY for behavioral changes):**
155+
If the change affects orchestration, activity, entity, or client/worker behavior,
156+
you **MUST** also add an **Azure Managed e2e test** in `test/e2e-azuremanaged/`.
157+
Do NOT skip this — it is a hard requirement, not optional. Follow the existing
158+
patterns (uses `DurableTaskAzureManagedClientBuilder` /
157159
`DurableTaskAzureManagedWorkerBuilder`, reads `DTS_CONNECTION_STRING` or
158160
`ENDPOINT`/`TASKHUB` env vars). Add the new test case to the appropriate existing
159161
spec file (e.g., `orchestration.spec.ts`, `entity.spec.ts`, `retry-advanced.spec.ts`).
162+
If you cannot add the e2e test, explain in the PR body **why** it was not feasible.
160163
- Keep changes minimal and focused — one concern per PR
161164

162165
### Labels
@@ -183,6 +186,11 @@ Before opening each PR, you MUST:
183186
- They must follow existing test patterns and conventions
184187
- They must actually test the fix (not just exist)
185188

189+
4. **Verify Azure Managed e2e tests were added (if applicable):**
190+
- If your change affects orchestration, activity, entity, or client/worker behavior,
191+
confirm you added a test in `test/e2e-azuremanaged/`
192+
- If you did not, you must either add one or document in the PR body why it was not feasible
193+
186194
**If any tests fail or lint errors appear:**
187195
- Fix them if they're caused by your changes
188196
- If pre-existing failures exist, note them in the PR body but do NOT let your changes add new failures

0 commit comments

Comments
 (0)