Skip to content

Commit 9e44e7c

Browse files
authored
fix: update daily code review agent to require tracking issues before PRs (#130)
1 parent 902f33d commit 9e44e7c

1 file changed

Lines changed: 22 additions & 3 deletions

File tree

.github/agents/daily-code-review.agent.md

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,27 @@ From all findings, select the **single most impactful** based on:
106106
- You can't write a meaningful test for it
107107
- It touches generated code or third-party dependencies
108108

109-
## Step 4: Create PR (1 Maximum)
109+
## Step 4: Create Tracking Issue (MANDATORY — Before Any PR)
110110

111-
For each selected finding, create a **separate PR** with:
111+
Before creating a PR, create a **GitHub issue** to track the finding:
112+
113+
### Issue Content
114+
115+
**Title:** `[copilot-finds] <Category>: <Clear one-line description>`
116+
117+
**Body must include:**
118+
1. **Problem** — What's wrong and why it matters (with file/line references)
119+
2. **Root Cause** — Why this happens
120+
3. **Proposed Fix** — High-level description of what the PR will change
121+
4. **Impact** — Severity and which scenarios are affected
122+
123+
**Labels:** Apply the `copilot-finds` label to the issue.
124+
125+
**Important:** Record the issue number — you will reference it in the PR.
126+
127+
## Step 5: Create PR (1 Maximum)
128+
129+
For the selected finding, create a **separate PR** linked to the tracking issue:
112130

113131
### Branch Naming
114132
`copilot-finds/<category>/<short-description>` where category is `bug`, `test`, or `improve`.
@@ -125,6 +143,7 @@ Example: `copilot-finds/bug/fix-unhandled-promise-rejection`
125143
3. **Fix** — What the PR changes and why this approach
126144
4. **Testing** — What new tests were added and what they verify
127145
5. **Risk** — What could go wrong with this change (be honest)
146+
6. **Tracking Issue**`Fixes #<issue-number>` (links to the tracking issue created in Step 4)
128147

129148
### Code Changes
130149
- Fix the actual problem
@@ -143,7 +162,7 @@ Example: `copilot-finds/bug/fix-unhandled-promise-rejection`
143162
### Labels
144163
Apply the `copilot-finds` label to every PR.
145164

146-
## Step 5: Quality Gates (MANDATORY — Do This Before Opening Each PR)
165+
## Step 6: Quality Gates (MANDATORY — Do This Before Opening Each PR)
147166

148167
Before opening each PR, you MUST:
149168

0 commit comments

Comments
 (0)