Skip to content

Commit fa2a17c

Browse files
YunchuWangCopilot
andcommitted
Correct inaccurate abandon comment re: Python provider
The single-work-item abandon path is JS-specific for the Azure Functions host integration. durabletask-python has no equivalent single-work-item helper, and its worker-loop abandon hands the item back over a real sidecar stub rather than no-opping, so the prior 'matches the Python provider, whose null stub no-ops' note was inaccurate. Comment-only change. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 0dcc47c commit fa2a17c

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

packages/durabletask-js/src/worker/task-hub-grpc-worker.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1270,7 +1270,9 @@ class CapturingSidecarStub {
12701270
// Abandon is a no-op for the single-work-item host path: the version-mismatch abandon branch
12711271
// in _executeOrchestratorInternal calls this, but processOrchestratorRequest only surfaces a
12721272
// completion response. Record it so the caller can distinguish an abandoned work item from a
1273-
// genuine "no response produced" failure. Matches the Python provider, whose null stub no-ops.
1273+
// genuine "no response produced" failure. This single-work-item helper is JS-specific for the
1274+
// Azure Functions host integration; durabletask-python has no equivalent helper, and its
1275+
// worker-loop abandon hands the item back over a real sidecar stub rather than no-opping here.
12741276
this.abandoned = true;
12751277
callback(null, new Empty());
12761278
}

0 commit comments

Comments
 (0)