From 5735fd8e27ce15f2e135e75acbd840484581e06b Mon Sep 17 00:00:00 2001
From: peterstone2017 <12449837+YunchuWang@users.noreply.github.com>
Date: Thu, 5 Mar 2026 14:03:47 -0800
Subject: [PATCH] Enforce Azure Managed e2e tests in daily-code-review agent

Make the requirement for Azure Managed e2e tests explicit and mandatory
when behavioral changes are made. The agent was frequently skipping these
tests. Changes:

- Mark Azure Managed e2e tests as MANDATORY (not just suggested)
- Add quality gate step to verify e2e tests were included
- Require justification in PR body if e2e tests are not feasible

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 .github/agents/daily-code-review.agent.md | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/.github/agents/daily-code-review.agent.md b/.github/agents/daily-code-review.agent.md
index 225cc1a..95a76af 100644
--- a/.github/agents/daily-code-review.agent.md
+++ b/.github/agents/daily-code-review.agent.md
@@ -151,12 +151,15 @@ Example: `copilot-finds/bug/fix-unhandled-promise-rejection`
   - Would have caught the bug (for bug fixes)
   - Cover the previously uncovered path (for missing tests)
   - Verify the improvement works (for improvements)
-- **If the change affects orchestration, activity, entity, or client/worker behavior:**
-  Add **Azure Managed e2e test(s)** in `test/e2e-azuremanaged/` as well. Follow the
-  existing patterns there (uses `DurableTaskAzureManagedClientBuilder` /
+- **Azure Managed e2e tests (MANDATORY for behavioral changes):**
+  If the change affects orchestration, activity, entity, or client/worker behavior,
+  you **MUST** also add an **Azure Managed e2e test** in `test/e2e-azuremanaged/`.
+  Do NOT skip this — it is a hard requirement, not optional. Follow the existing
+  patterns (uses `DurableTaskAzureManagedClientBuilder` /
   `DurableTaskAzureManagedWorkerBuilder`, reads `DTS_CONNECTION_STRING` or
   `ENDPOINT`/`TASKHUB` env vars). Add the new test case to the appropriate existing
   spec file (e.g., `orchestration.spec.ts`, `entity.spec.ts`, `retry-advanced.spec.ts`).
+  If you cannot add the e2e test, explain in the PR body **why** it was not feasible.
 - Keep changes minimal and focused — one concern per PR
 
 ### Labels
@@ -183,6 +186,11 @@ Before opening each PR, you MUST:
    - They must follow existing test patterns and conventions
    - They must actually test the fix (not just exist)
 
+4. **Verify Azure Managed e2e tests were added (if applicable):**
+   - If your change affects orchestration, activity, entity, or client/worker behavior,
+     confirm you added a test in `test/e2e-azuremanaged/`
+   - If you did not, you must either add one or document in the PR body why it was not feasible
+
 **If any tests fail or lint errors appear:**
 - Fix them if they're caused by your changes
 - If pre-existing failures exist, note them in the PR body but do NOT let your changes add new failures