Skip to content

Enforce Azure Managed e2e tests in daily-code-review agent #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YunchuWang merged 1 commit into from
Mar 5, 2026
Merged

Enforce Azure Managed e2e tests in daily-code-review agent #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/agents/daily-code-review.agent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,12 +151,15 @@ Example: `copilot-finds/bug/fix-unhandled-promise-rejection`
- Would have caught the bug (for bug fixes)
- Cover the previously uncovered path (for missing tests)
- Verify the improvement works (for improvements)
- **If the change affects orchestration, activity, entity, or client/worker behavior:**
Add **Azure Managed e2e test(s)** in `test/e2e-azuremanaged/` as well. Follow the
existing patterns there (uses `DurableTaskAzureManagedClientBuilder` /
- **Azure Managed e2e tests (MANDATORY for behavioral changes):**
If the change affects orchestration, activity, entity, or client/worker behavior,
you **MUST** also add an **Azure Managed e2e test** in `test/e2e-azuremanaged/`.
Do NOT skip this — it is a hard requirement, not optional. Follow the existing
patterns (uses `DurableTaskAzureManagedClientBuilder` /
`DurableTaskAzureManagedWorkerBuilder`, reads `DTS_CONNECTION_STRING` or
`ENDPOINT`/`TASKHUB` env vars). Add the new test case to the appropriate existing
spec file (e.g., `orchestration.spec.ts`, `entity.spec.ts`, `retry-advanced.spec.ts`).
If you cannot add the e2e test, explain in the PR body **why** it was not feasible.
- Keep changes minimal and focused — one concern per PR

### Labels
Expand All @@ -183,6 +186,11 @@ Before opening each PR, you MUST:
- They must follow existing test patterns and conventions
- They must actually test the fix (not just exist)

4. **Verify Azure Managed e2e tests were added (if applicable):**
- If your change affects orchestration, activity, entity, or client/worker behavior,
confirm you added a test in `test/e2e-azuremanaged/`
- If you did not, you must either add one or document in the PR body why it was not feasible

**If any tests fail or lint errors appear:**
- Fix them if they're caused by your changes
- If pre-existing failures exist, note them in the PR body but do NOT let your changes add new failures
Expand Down
Loading