-
Notifications
You must be signed in to change notification settings - Fork 10
Update dependencies, ESLint configuration, and add pull request template #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| # Summary | ||
|
|
||
| ## What changed? | ||
| - | ||
|
|
||
| ## Why is this change needed? | ||
| - | ||
|
|
||
| ## Issues / work items | ||
| - Resolves # | ||
| - Related # | ||
|
|
||
| --- | ||
|
|
||
| # Project checklist | ||
| - [ ] Release notes are not required for the next release | ||
| - [ ] Otherwise: Notes added to `CHANGELOG.md` | ||
| - [ ] Backport is not required | ||
| - [ ] Otherwise: Backport tracked by issue/PR #issue_or_pr | ||
| - [ ] All required tests have been added/updated (unit tests, E2E tests) | ||
| - [ ] Breaking change? | ||
| - [ ] If yes: | ||
| - Impact: | ||
| - Migration guidance: | ||
|
|
||
| --- | ||
|
|
||
| # AI-assisted code disclosure (required) | ||
|
|
||
| ## Was an AI tool used? (select one) | ||
| - [ ] No | ||
| - [ ] Yes, AI helped write parts of this PR (e.g., GitHub Copilot) | ||
| - [ ] Yes, an AI agent generated most of this PR | ||
|
|
||
| If AI was used: | ||
| - Tool(s): | ||
| - AI-assisted areas/files: | ||
| - What you changed after AI output: | ||
|
|
||
| AI verification (required if AI was used): | ||
| - [ ] I understand the code and can explain it | ||
| - [ ] I verified referenced APIs/types exist and are correct | ||
| - [ ] I reviewed edge cases/failure paths (timeouts, retries, cancellation, exceptions) | ||
| - [ ] I reviewed concurrency/async behavior | ||
| - [ ] I checked for unintended breaking or behavior changes | ||
|
|
||
| --- | ||
|
|
||
| # Testing | ||
|
|
||
| ## Automated tests | ||
| - Result: Passed / Failed (link logs if failed) | ||
|
|
||
| ## Manual validation (only if runtime/behavior changed) | ||
| - Environment (OS, Node.js version, components): | ||
| - Steps + observed results: | ||
| 1. | ||
| 2. | ||
| 3. | ||
| - Evidence (optional): | ||
|
|
||
| --- | ||
|
|
||
| # Notes for reviewers | ||
| - N/A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| import eslint from "@eslint/js"; | ||
| import tseslint from "typescript-eslint"; | ||
| import globals from "globals"; | ||
|
|
||
| export default tseslint.config( | ||
| eslint.configs.recommended, | ||
| ...tseslint.configs.recommended, | ||
| { | ||
| languageOptions: { | ||
| ecmaVersion: 2020, | ||
| sourceType: "module", | ||
| globals: { | ||
| ...globals.browser, | ||
| ...globals.node, | ||
| ...globals.amd, | ||
|
torosent marked this conversation as resolved.
Outdated
|
||
| }, | ||
| }, | ||
| rules: { | ||
| "@typescript-eslint/ban-ts-comment": "off", | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
| "@typescript-eslint/no-inferrable-types": "off", | ||
| "@typescript-eslint/no-empty-function": "off", | ||
| "@typescript-eslint/no-require-imports": "off", | ||
| "no-constant-condition": "off", | ||
| "@typescript-eslint/no-unused-vars": [ | ||
| "error", | ||
| { | ||
| varsIgnorePattern: "^_", | ||
| argsIgnorePattern: "^_", | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| { | ||
| ignores: [ | ||
| "**/dist/**", | ||
| "**/node_modules/**", | ||
| "**/src/version.ts", | ||
| "**/jest.config.js", | ||
| "**/src/proto/**", | ||
| ], | ||
| } | ||
| ); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, this is the recommended way to put this in eslint.config