Merge pull request #303 from microsoft/stevosyan/failure-details-bug-fix

Bug fix for correctly generating the `ExecutionCompletedEvent`

Author: sophiatev

CHANGELOG.md

@@ -4,6 +4,12 @@
 
 ### Updates
 
+* Bug fix for correctly generating the `ExecutionCompletedEvent` ([#303](https://github.com/microsoft/durabletask-mssql/pull/303))
+
+## v1.5.3
+
+### Updates
+
 * Add logic to terminate suspended instances ([#301](https://github.com/microsoft/durabletask-mssql/pull/301))
 
 ## v1.5.2

src/DurableTask.SqlServer/SqlUtils.cs

@@ -76,11 +76,16 @@ public static HistoryEvent GetHistoryEvent(this DbDataReader reader, bool isOrch
                     };
                     break;
                 case EventType.ExecutionCompleted:
-                    TryGetFailureDetails(reader, out FailureDetails? executionFailedDetails);
+                    FailureDetails? executionFailedDetails = null;
+                    OrchestrationStatus orchestrationStatus = GetRuntimeStatus(reader);
+                    if (orchestrationStatus == OrchestrationStatus.Failed)
+                    {
+                        TryGetFailureDetails(reader, out executionFailedDetails);
+                    }
                     historyEvent = new ExecutionCompletedEvent(
                         eventId,
                         result: GetPayloadText(reader),
-                        orchestrationStatus: GetRuntimeStatus(reader),
+                        orchestrationStatus: orchestrationStatus,
                         failureDetails: executionFailedDetails);
                     break;
                 case EventType.ExecutionStarted:

src/common.props

@@ -17,7 +17,7 @@
   <PropertyGroup>
     <MajorVersion>1</MajorVersion>
     <MinorVersion>5</MinorVersion>
-    <PatchVersion>3</PatchVersion>
+    <PatchVersion>4</PatchVersion>
     <VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
     <VersionSuffix></VersionSuffix>
     <AssemblyVersion>$(MajorVersion).$(MinorVersion).0.0</AssemblyVersion>

test/DurableTask.SqlServer.Tests/Integration/DatabaseManagement.cs

@@ -505,7 +505,7 @@ async Task ValidateDatabaseSchemaAsync(TestDatabase database, string schemaName
                 schemaName);
             Assert.Equal(1, currentSchemaVersion.Major);
             Assert.Equal(5, currentSchemaVersion.Minor);
-            Assert.Equal(3, currentSchemaVersion.Patch);
+            Assert.Equal(4, currentSchemaVersion.Patch);
         }
 
         sealed class TestDatabase : IDisposable