Add on-demand sandbox activity protos#74
Open
YunchuWang wants to merge 9 commits into
Open
Conversation
Adds the on-demand sandbox activity service proto and the scheduler managed identity fields needed by the preview SDK work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
YunchuWang
commented
Jun 10, 2026
Removes the unused GetWorkItemsRequest.worker_instance_id field and the stale reserved name from the on-demand sandbox worker start message. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
YunchuWang
commented
Jun 10, 2026
Removes the unused reserved field number from the new on-demand sandbox worker start message. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
cgillum
reviewed
Jun 11, 2026
halspang
reviewed
Jun 12, 2026
halspang
left a comment
Member
There was a problem hiding this comment.
Some nits and some questions that may be more about the actual feature instead of this proto directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario
Durable Task Scheduler needs a shared protobuf contract for sandbox activity workers.
The contract covers two related moments:
The .NET and Python preview SDKs both depend on this contract, so the names in the proto become the vocabulary reviewers and SDK users see everywhere else.
What's missing
The first version still used
on_demand_sandboxnaming and asubstratefield name.That made the contract feel tied to an implementation detail instead of the customer-facing sandbox worker model. It also forced downstream SDKs to either expose the same awkward names or carry translation layers around them.
Review feedback settled on the clearer vocabulary: the service is about sandbox activities, and the provider selector should be named
SandboxProviderKindwith field namesandbox_provider.The change
The protobuf surface is renamed around the sandbox worker model.
A good review path is:
protos/sandbox_service.proto. This is the source-of-truth contract: packagemicrosoft.durabletask.sandboxes, serviceSandboxActivities, and enumSandboxProviderKind.SandboxActivityWorkerStartnow carriessandbox_provider, and the rest of the stream still covers worker registration, heartbeat capacity, and responses from DTS.The old
on_demand_sandbox_activities_service.protosurface is replaced bysandbox_service.protoso downstream SDKs can generate and expose the sameSandbox*vocabulary.