Skip to content

Commit 47517af

Browse files
committed
Tighten sandbox activity metadata validation
1 parent 732fd59 commit 47517af

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

durabletask-azuremanaged/durabletask/azuremanaged/preview/sandboxes/declarations.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ def _normalize_memory(value: str) -> str:
245245
def _try_parse_cpu_millicores(value: str) -> Optional[int]:
246246
try:
247247
if value[-1:].lower() == "m":
248-
return int(Decimal(value[:-1]))
248+
return int(value[:-1])
249249
return int(Decimal(value) * 1000)
250250
except (InvalidOperation, ValueError):
251251
return None

durabletask-azuremanaged/durabletask/azuremanaged/preview/sandboxes/helpers.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ def resolve_activity_names(activity_names: str | Iterable[str]) -> list[str]:
1616
names = [activity_names] if isinstance(activity_names, str) else activity_names
1717
for name in names:
1818
normalized = name.strip()
19-
if normalized and normalized not in seen:
19+
key = normalized.casefold()
20+
if normalized and key not in seen:
2021
resolved.append(normalized)
21-
seen.add(normalized)
22+
seen.add(key)
2223
return resolved

tests/durabletask-azuremanaged/test_sandboxes_extension.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626

2727
def test_resolve_activity_names_trims_and_deduplicates() -> None:
28-
assert resolve_activity_names([" RemoteHello ", "", "RemoteHello", "Other"]) == [
28+
assert resolve_activity_names([" RemoteHello ", "", "RemoteHello", "remotehello", "Other"]) == [
2929
"RemoteHello",
3030
"Other",
3131
]
@@ -209,6 +209,7 @@ def test_build_sandbox_activity_declaration_rejects_invalid_adc_resource_quantit
209209
for cpu, memory, expected_message in [
210210
("0", "1024Mi", "CPU"),
211211
("0m", "1024Mi", "CPU"),
212+
("500.5m", "1024Mi", "CPU"),
212213
("500Mi", "1024Mi", "CPU"),
213214
("500m", "0", "memory"),
214215
("500m", "0Mi", "memory"),

0 commit comments

Comments
 (0)