The problem with implementing was that this requires us to keep state whether the menu was opened by clicking on it or focus moved to it programmatically (e.g. via tab handling).

Relevant code:

edit/src/tui.rs

Lines 2992 to 3033 in d74c330

    
               pub fn menubar_menu_begin(&mut self, text: &str, accelerator: char) -> bool { 
        
                   let mixin = self.tree.current_node.borrow().child_count as u64; 
        
                   self.next_block_id_mixin(mixin); 
        
                   self.menubar_label(text, accelerator, None); 
        
                   self.attr_focusable(); 
        
                   self.attr_padding(Rect::two(0, 1)); 
        
                   let contains_focus = self.contains_focus(); 
        
                   let keyboard_focus = !contains_focus 
        
                       && self.consume_shortcut(kbmod::ALT | InputKey::new(accelerator as u32)); 
        
                   if contains_focus || keyboard_focus { 
        
                       self.attr_background_rgba(self.tui.floater_default_bg); 
        
                       self.attr_foreground_rgba(self.tui.floater_default_fg); 
        
                       if self.is_focused() { 
        
                           self.attr_background_rgba(self.indexed(IndexedColor::Green)); 
        
                           self.attr_foreground_rgba(self.contrasted(self.indexed(IndexedColor::Green))); 
        
                       } 
        
                       self.next_block_id_mixin(mixin); 
        
                       self.table_begin("flyout"); 
        
                       self.attr_float(FloatSpec { 
        
                           anchor: Anchor::Last, 
        
                           gravity_x: 0.0, 
        
                           gravity_y: 0.0, 
        
                           offset_x: 0.0, 
        
                           offset_y: 1.0, 
        
                       }); 
        
                       self.attr_border(); 
        
                       self.attr_focus_well(); 
        
                       if keyboard_focus { 
        
                           self.steal_focus(); 
        
                       } 
        
                       true 
        
                   } else { 
        
                       false 
        
                   } 
        
               }

	pub fn menubar_menu_begin(&mut self, text: &str, accelerator: char) -> bool {
	let mixin = self.tree.current_node.borrow().child_count as u64;
	self.next_block_id_mixin(mixin);

	self.menubar_label(text, accelerator, None);
	self.attr_focusable();
	self.attr_padding(Rect::two(0, 1));

	let contains_focus = self.contains_focus();
	let keyboard_focus = !contains_focus
	&& self.consume_shortcut(kbmod::ALT \| InputKey::new(accelerator as u32));

	if contains_focus \|\| keyboard_focus {
	self.attr_background_rgba(self.tui.floater_default_bg);
	self.attr_foreground_rgba(self.tui.floater_default_fg);

	if self.is_focused() {
	self.attr_background_rgba(self.indexed(IndexedColor::Green));
	self.attr_foreground_rgba(self.contrasted(self.indexed(IndexedColor::Green)));
	}

	self.next_block_id_mixin(mixin);
	self.table_begin("flyout");
	self.attr_float(FloatSpec {
	anchor: Anchor::Last,
	gravity_x: 0.0,
	gravity_y: 0.0,
	offset_x: 0.0,
	offset_y: 1.0,
	});
	self.attr_border();
	self.attr_focus_well();

	if keyboard_focus {
	self.steal_focus();
	}

	true
	} else {
	false
	}
	}

Uh oh!

Toggle menus #80

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions