Use compatible checkbox marker glyphs#840
Open
barkure wants to merge 2 commits intomicrosoft:mainfrom
Open
Conversation
Member
Contributor
Author
|
Thanks for the context. I switched the markers to U+25FC / U+25FB and verified the updated build locally. |
Member
|
It is unfortunately necessary to test these new glyphs vs the old ones on a variety of terminals and fonts. If you could test at least a subset of that, it would help me a lot! |
Contributor
Author
|
I tested the new glyphs against the old ones on a subset of terminals and fonts. macOS:
Fonts tested:
Windows:
Fonts tested:
I didn't notice any obvious rendering issues in this subset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #747.
🗹(U+1F5F9 BALLOT BOX WITH BOLD CHECK) with■(U+25A0 BLACK SQUARE).☐(U+2610 BALLOT BOX) with□(U+25A1 WHITE SQUARE).■/□pair also improves visual consistency between checked and unchecked states.Happy to use a different marker pair if maintainers prefer another option.
Test plan