Skip to content

Commit 5874763

Browse files
KupoCatTomer WintnerCopilot
authored
Remove 'host-app/' prefix from User-Agent host app suffix (#262)
Co-authored-by: Tomer Wintner <tomerwintner@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 6256ac0 commit 5874763

3 files changed

Lines changed: 22 additions & 16 deletions

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
kind: fixed
2+
body: Remove invalid 'host-app/' prefix from User-Agent host app suffix
3+
time: 2026-07-06T16:51:04+03:00
4+
custom:
5+
Author: KupoCat
6+
AuthorLink: https://github.com/KupoCat

src/fabric_cli/client/fab_api_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ def _build_user_agent(ctxt_cmd: str) -> str:
297297
"""Build the User-Agent header for API requests.
298298
299299
Example:
300-
ms-fabric-cli/1.0.0 (create; Windows/10; Python/3.10.2) host-app/ado/2.0.0
300+
ms-fabric-cli/1.0.0 (create; Windows/10; Python/3.10.2) ado/2.0.0
301301
"""
302302
user_agent = (
303303
f"{fab_constant.API_USER_AGENT}/{fab_constant.FAB_VERSION} "
@@ -332,7 +332,7 @@ def _get_host_app() -> str:
332332
if not host_app_name:
333333
return ""
334334

335-
host_app = f" host-app/{host_app_name.lower()}"
335+
host_app = f" {host_app_name.lower()}"
336336

337337
# Check for optional version
338338
host_app_version = os.environ.get(fab_constant.FAB_HOST_APP_VERSION_ENV_VAR)

tests/test_core/test_fab_api_client.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -316,17 +316,17 @@ def __init__(self):
316316
(
317317
"Fabric-AzureDevops-Extension",
318318
None,
319-
" host-app/fabric-azuredevops-extension",
319+
" fabric-azuredevops-extension",
320320
),
321321
(
322322
"Fabric-AzureDevops-Extension",
323323
"1.2.0",
324-
" host-app/fabric-azuredevops-extension/1.2.0",
324+
" fabric-azuredevops-extension/1.2.0",
325325
),
326326
(
327327
"fabric-azuredevops-extension",
328328
"1.2.0",
329-
" host-app/fabric-azuredevops-extension/1.2.0",
329+
" fabric-azuredevops-extension/1.2.0",
330330
),
331331
("Invalid-App", "1.0.0", ""),
332332
("", None, ""),
@@ -335,47 +335,47 @@ def __init__(self):
335335
(
336336
"Fabric-AzureDevops-Extension",
337337
"1.2.0.4", # Invalid format
338-
" host-app/fabric-azuredevops-extension",
338+
" fabric-azuredevops-extension",
339339
),
340340
(
341341
"Fabric-AzureDevops-Extension",
342342
"1.2.a", # Invalid format
343-
" host-app/fabric-azuredevops-extension",
343+
" fabric-azuredevops-extension",
344344
),
345345
(
346346
"Fabric-AzureDevops-Extension",
347347
"a.b.c", # Invalid format
348-
" host-app/fabric-azuredevops-extension",
348+
" fabric-azuredevops-extension",
349349
),
350350
(
351351
"Fabric-AzureDevops-Extension",
352352
"1", # valid format
353-
" host-app/fabric-azuredevops-extension/1",
353+
" fabric-azuredevops-extension/1",
354354
),
355355
(
356356
"Fabric-AzureDevops-Extension",
357357
"1.2", # valid format
358-
" host-app/fabric-azuredevops-extension/1.2",
358+
" fabric-azuredevops-extension/1.2",
359359
),
360360
(
361361
"Fabric-AzureDevops-Extension",
362362
"1.0.0", # valid format
363-
" host-app/fabric-azuredevops-extension/1.0.0",
363+
" fabric-azuredevops-extension/1.0.0",
364364
),
365365
(
366366
"Fabric-AzureDevops-Extension",
367367
"1.0.0-rc.1", # valid format
368-
" host-app/fabric-azuredevops-extension/1.0.0-rc.1",
368+
" fabric-azuredevops-extension/1.0.0-rc.1",
369369
),
370370
(
371371
"Fabric-AzureDevops-Extension",
372372
"1.0.0-alpha", # valid format
373-
" host-app/fabric-azuredevops-extension/1.0.0-alpha",
373+
" fabric-azuredevops-extension/1.0.0-alpha",
374374
),
375375
(
376376
"Fabric-AzureDevops-Extension",
377377
"1.0.0-beta", # valid format
378-
" host-app/fabric-azuredevops-extension/1.0.0-beta",
378+
" fabric-azuredevops-extension/1.0.0-beta",
379379
),
380380
],
381381
)
@@ -416,12 +416,12 @@ def setup_default_private_links(mock_fab_set_state_config):
416416
(
417417
"Fabric-AzureDevops-Extension",
418418
None,
419-
" host-app/fabric-azuredevops-extension",
419+
" fabric-azuredevops-extension",
420420
),
421421
(
422422
"Fabric-AzureDevops-Extension",
423423
"1.2.0",
424-
" host-app/fabric-azuredevops-extension/1.2.0",
424+
" fabric-azuredevops-extension/1.2.0",
425425
),
426426
# Invalid app name - host-app suffix is omitted entirely from User-Agent
427427
("Invalid-App", "1.0.0", ""),

0 commit comments

Comments
 (0)