Skip to content

Commit 7961c72

Browse files
Copilotvnbaaij
andauthored
fix: rename custom events whose name matches browserEventName to avoid .NET 11 exception (#4607)
* Initial plan * fix: rename custom events with same name as browserEventName to avoid .NET 11 exception Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com> * chore: remove accidentally committed build artifact and update .gitignore Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com> * fix: rename custom events to listchange/textimmediate and revert .gitignore Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com> * chore: add Core.Scripts/.gitignore and remove committed build artifact Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com> * chore: update Core.Scripts/.gitignore and remove committed build artifact Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com> * chore: remove build artifact with backslash path from git tracking Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com> * chore: revert package-lock.json and remove Core.Scripts/.gitignore Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
1 parent 3ec2983 commit 7961c72

7 files changed

Lines changed: 9 additions & 9 deletions

File tree

src/Core.Scripts/src/FluentUICustomEvents.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export namespace Microsoft.FluentUI.Blazor.FluentUICustomEvents {
8787
}
8888
});
8989

90-
blazor.registerCustomEventType('listboxchange', {
90+
blazor.registerCustomEventType('listchange', {
9191
browserEventName: 'listboxchange',
9292
createEventArgs: (event: any)=> {
9393
return {
@@ -155,7 +155,7 @@ export namespace Microsoft.FluentUI.Blazor.FluentUICustomEvents {
155155
}
156156

157157
export function TextInput(blazor: Blazor) {
158-
blazor.registerCustomEventType('immediate', {
158+
blazor.registerCustomEventType('textimmediate', {
159159
browserEventName: 'immediate',
160160
createEventArgs: (event: any)=> {
161161
return {

src/Core/Components/List/FluentListbox.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
name="@Name"
1919
readonly="@ReadOnly"
2020
required="@Required"
21-
@onlistboxchange="@OnDropdownChangeHandlerAsync"
21+
@onlistchange="@OnDropdownChangeHandlerAsync"
2222
@onfocusout="@FocusOutHandlerAsync"
2323
@attributes="@AdditionalAttributes">
2424
<fluent-listbox style="@ListStyle">

src/Core/Components/TextArea/FluentTextArea.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
value="@CurrentValueAsString"
2727
@onfocusout="@FocusOutHandlerAsync"
2828
@onchange="@ChangeHandlerAsync"
29-
@onimmediate="@InputHandlerAsync"
29+
@ontextimmediate="@InputHandlerAsync"
3030
@attributes="AdditionalAttributes">
3131
</fluent-textarea>
3232
</FluentField>

src/Core/Components/TextInput/FluentTextInput.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
value="@CurrentValueAsString"
2828
@onfocusout="@FocusOutHandlerAsync"
2929
@onchange="@ChangeHandlerAsync"
30-
@onimmediate="@InputHandlerAsync"
30+
@ontextimmediate="@InputHandlerAsync"
3131
@attributes="AdditionalAttributes">
3232

3333
@if (StartTemplate != null)

src/Core/Events/EventHandlers.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@ namespace Microsoft.FluentUI.AspNetCore.Components;
3333
[EventHandler("onmenuitemchange", typeof(MenuItemEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
3434
[EventHandler("ontabchange", typeof(TabChangeEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
3535
[EventHandler("ondropdownchange", typeof(DropdownEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
36-
[EventHandler("onlistboxchange", typeof(DropdownEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
36+
[EventHandler("onlistchange", typeof(DropdownEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
3737
[EventHandler("ontreechanged", typeof(TreeItemChangedEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
3838
[EventHandler("ontreetoggle", typeof(TreeItemToggleEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
3939
[EventHandler("onclosecolumnoptions", typeof(EventArgs), enableStopPropagation: true, enablePreventDefault: true)]
4040
[EventHandler("onclosecolumnresize", typeof(EventArgs), enableStopPropagation: true, enablePreventDefault: true)]
4141
[EventHandler("onradiochange", typeof(RadioEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
42-
[EventHandler("onimmediate", typeof(ChangeEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
42+
[EventHandler("ontextimmediate", typeof(ChangeEventArgs), enableStopPropagation: true, enablePreventDefault: true)]
4343
public static class EventHandlers
4444
{
4545
}

tests/Core/Components/TextArea/FluentTextAreaTests.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@
146146
var cut = Render(@<FluentTextArea @bind-Value="@value" Immediate="@immediate" ImmediateDelay="@immediateDelay" />);
147147

148148
// Act
149-
cut.Find("fluent-textarea").TriggerEvent("onimmediate", new ChangeEventArgs() { Value = "new value"});
149+
cut.Find("fluent-textarea").TriggerEvent("ontextimmediate", new ChangeEventArgs() { Value = "new value"});
150150

151151
// Assert: Immediate
152152
Assert.Equal(expectedImmediateValue, value);

tests/Core/Components/TextInput/FluentTextInputTests.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
var cut = Render(@<FluentTextInput @bind-Value="@value" Immediate="@immediate" ImmediateDelay="@immediateDelay" />);
162162

163163
// Act
164-
cut.Find("fluent-text-input").TriggerEvent("onimmediate", new ChangeEventArgs() { Value = "new value"});
164+
cut.Find("fluent-text-input").TriggerEvent("ontextimmediate", new ChangeEventArgs() { Value = "new value"});
165165

166166
// Assert: Immediate
167167
Assert.Equal(expectedImmediateValue, value);

0 commit comments

Comments
 (0)