Implement externalized defaults naming convention for FluentButton parameters#3858
Closed
Copilot wants to merge 1 commit into
Closed
Implement externalized defaults naming convention for FluentButton parameters#3858Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Rename DefaultButtonAppearance to Appearance in FluentDefault usage for FluentButton
Implement externalized defaults naming convention for FluentButton parameters
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the critical naming convention requirement for externalized defaults classes in FluentUI Blazor components. The key issue is ensuring that property names in static defaults classes exactly match component parameter names for the externalized defaults system to work correctly.
Problem
When using externalized defaults with attributes like
[FluentDefault("FluentButton")], property names in defaults classes must exactly match the component's parameter names. Using incorrect names likeDefaultButtonAppearanceinstead ofAppearancewould cause:Solution
Infrastructure Added
Key Requirements Implemented
Appearance(notDefaultButtonAppearance)[FluentDefault("ComponentName")]attributeExample
Correct Pattern:
Incorrect Pattern (prevented by this PR):
Validation
Appearance="Appearance.Accent"syntaxDefaultButtonAppearancefound in current codebaseThis ensures that when the externalized defaults system is fully implemented, all components will work correctly with their configured defaults.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
4vyvsblobprodcus361.vsblob.vsassets.iodotnet build --no-restore --verbosity minimal(dns block)dotnet restore src/Core/Microsoft.FluentUI.AspNetCore.Components.csproj(dns block)8xbvsblobprodcus382.vsblob.vsassets.iodotnet build --no-restore --verbosity minimal(dns block)bcnvsblobprodcus378.vsblob.vsassets.iodotnet build --no-restore --verbosity minimal(dns block)i1qvsblobprodcus353.vsblob.vsassets.iodotnet build --no-restore --verbosity minimal(dns block)l49vsblobprodcus358.vsblob.vsassets.iodotnet build --no-restore --verbosity minimal(dns block)mfjvsblobprodcus373.vsblob.vsassets.iodotnet build --no-restore --verbosity minimal(dns block)s4uvsblobprodcus326.vsblob.vsassets.iodotnet build --no-restore --verbosity minimal(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.