[dev-v5][Wizard] Migrate FluentWizard#4682
Open
MarvinKlein1508 wants to merge 24 commits intomicrosoft:dev-v5from
Open
[dev-v5][Wizard] Migrate FluentWizard#4682MarvinKlein1508 wants to merge 24 commits intomicrosoft:dev-v5from
FluentWizard#4682MarvinKlein1508 wants to merge 24 commits intomicrosoft:dev-v5from
Conversation
Check if ValueChanged.HasDelegate. internal FluentWizard in FluentWizardStep
dvoituron
requested changes
Apr 7, 2026
| /// <summary /> | ||
| protected override void OnParametersSet() | ||
| { | ||
| SetCurrentValue(Value); |
Collaborator
There was a problem hiding this comment.
OnParametersSet is triggered multiple times (every time a parameter is modified). This causes performance issues if you modify Value each time in this method. You should use a different approach: detect when the value changes or use SetParametersAsync(ParameterView) or ...
| /// Gets or sets the label for the Previous button. | ||
| /// If null or empty, the localized value is used. | ||
| /// </summary> | ||
| public static string? LabelButtonPrevious { get; set; } |
Collaborator
There was a problem hiding this comment.
Do not use static properties (this was a workaround in v4, but now we have the Localizer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR adds the
FluentWizardcomponent to v5. Based on the works of @agriffard and #4640I processed the review comments and adjusted the examples and added more tests. Right now there are some tests missing for
FluentWizard,FluentWizardStepand all tests forFluentWizardStepValidator🎫 Issues
Fixes: #4191
👩💻 Reviewer Notes
This PR is a draft to discuss the current implementation before we add the remaining tests (in case we change something)
📑 Test Plan
✅ Checklist
General
Component-specific
⏭ Next Steps