Skip to content

Commit 8c1c85c

Browse files
authored
React-cap-theme: Removed props being omitted from base Fluent (#651)
1 parent ad57c12 commit 8c1c85c

8 files changed

Lines changed: 25 additions & 24 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "minor",
3+
"comment": "removed omit & picks for components removing types",
4+
"packageName": "@fluentui-contrib/react-cap-theme",
5+
"email": "miceclavea@microsoft.com",
6+
"dependentChangeType": "patch"
7+
}

packages/react-cap-theme/src/components/react-button/components/Button/Button.types.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,7 @@ export type ButtonAppearance =
1616
| 'transparent';
1717

1818
export type ButtonProps = ComponentProps<ButtonSlots> &
19-
Pick<
20-
BaseButtonProps,
21-
'disabledFocusable' | 'disabled' | 'iconPosition' | 'size'
22-
> & {
19+
Omit<BaseButtonProps, 'appearance'> & {
2320
appearance?: ButtonAppearance;
2421
};
2522

packages/react-cap-theme/src/components/react-button/components/MenuButton/MenuButton.types.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@ import type { ButtonProps, ButtonState, ButtonSlots } from '../../Button';
55
export type { MenuButtonSlots } from '@fluentui/react-button';
66

77
export type MenuButtonProps = ComponentProps<MenuButtonSlots> &
8-
Pick<ButtonProps, 'appearance' | 'disabled' | 'disabledFocusable' | 'size'>;
8+
Pick<
9+
ButtonProps,
10+
'appearance' | 'disabled' | 'disabledFocusable' | 'shape' | 'size'
11+
>;
912

1013
export type MenuButtonState = ComponentState<MenuButtonSlots> &
1114
Omit<ButtonState, keyof ButtonSlots | 'components' | 'iconPosition'>;

packages/react-cap-theme/src/components/react-button/components/ToggleButton/ToggleButton.types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import type { ToggleButtonProps as BaseToggleButtonProps } from '@fluentui/react
22
import type { ButtonProps, ButtonState } from '../../Button';
33

44
export type ToggleButtonProps = ButtonProps &
5-
Pick<BaseToggleButtonProps, 'defaultChecked' | 'checked'>;
5+
Omit<BaseToggleButtonProps, 'appearance'>;
66

77
export type ToggleButtonState = ButtonState &
88
Required<Pick<ToggleButtonProps, 'checked'>>;

packages/react-cap-theme/src/components/react-carousel/components/CarouselAutoplayButton/CarouselAutoplayButton.types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ import type {
1010
} from '../../../react-button/components/ToggleButton/ToggleButton.types';
1111

1212
export type CarouselAutoplayButtonSlots = ButtonSlots &
13-
Pick<FluentCarouselAutoplayButtonSlots, 'root'>;
13+
FluentCarouselAutoplayButtonSlots;
1414

1515
export type CarouselAutoplayButtonProps = ToggleButtonProps &
1616
ComponentProps<CarouselAutoplayButtonSlots> &
17-
Pick<FluentCarouselAutoplayButtonProps, 'onCheckedChange'>;
17+
Omit<FluentCarouselAutoplayButtonProps, 'appearance'>;
1818

1919
export type CarouselAutoplayButtonState = ToggleButtonState &
2020
ComponentState<CarouselAutoplayButtonSlots>;

packages/react-cap-theme/src/components/react-carousel/components/CarouselButton/CarouselButton.types.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,17 @@ import type {
44
CarouselButtonState as FluentCarouselButtonState,
55
} from '@fluentui/react-carousel';
66
import type { ComponentProps, ComponentState } from '@fluentui/react-utilities';
7-
import type { ButtonSlots } from '@fluentui/react-button';
87
import type { ButtonProps, ButtonState } from '../../../react-button';
98

10-
export type CarouselButtonSlots = ButtonSlots &
11-
Pick<FluentCarouselButtonSlots, 'root'>;
9+
export type CarouselButtonSlots = FluentCarouselButtonSlots;
1210

1311
export type CarouselButtonProps = Partial<ButtonProps> &
1412
ComponentProps<CarouselButtonSlots> &
15-
Pick<FluentCarouselButtonProps, 'navType'>;
13+
Omit<FluentCarouselButtonProps, 'appearance'>;
1614

1715
export type CarouselButtonState = ButtonState &
1816
ComponentState<CarouselButtonSlots> &
19-
Pick<FluentCarouselButtonState, 'navType'>;
17+
Omit<FluentCarouselButtonState, 'appearance'>;
2018

2119
export type {
2220
CarouselButtonProps as FluentCarouselButtonProps,

packages/react-cap-theme/src/components/react-carousel/components/CarouselNavContainer/CarouselNavContainer.types.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ export type CarouselNavContainerSlots = Omit<
2222

2323
export type CarouselNavContainerProps =
2424
ComponentProps<CarouselNavContainerSlots> &
25-
Pick<FluentCarouselNavContainerProps, 'layout'>;
25+
Omit<
26+
FluentCarouselNavContainerProps,
27+
keyof ComponentProps<FluentCarouselNavContainerSlots>
28+
>;
2629

2730
export type CarouselNavContainerState =
2831
ComponentState<CarouselNavContainerSlots> &

packages/react-cap-theme/src/components/react-tooltip/components/Tooltip/Tooltip.types.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,11 @@
1-
import type { PortalProps } from '@fluentui/react-portal';
21
import type {
32
TooltipProps as BaseTooltipProps,
43
TooltipState as BaseTooltipState,
5-
TooltipSlots,
6-
TooltipTriggerProps,
74
} from '@fluentui/react-tooltip';
8-
import type { ComponentProps, TriggerProps } from '@fluentui/react-utilities';
95

10-
export type TooltipProps = ComponentProps<TooltipSlots> &
11-
TriggerProps<TooltipTriggerProps> &
12-
Pick<PortalProps, 'mountNode'> &
13-
Omit<BaseTooltipProps, 'appearance' | 'withArrow'> & {
14-
appearance?: 'normal' | 'inverted' | 'brand';
15-
};
6+
export type TooltipProps = BaseTooltipProps & {
7+
appearance?: 'normal' | 'inverted' | 'brand';
8+
};
169

1710
export type TooltipState = BaseTooltipState & {
1811
extendedAppearance: 'normal' | 'inverted' | 'brand';

0 commit comments

Comments
 (0)