Skip to content

fix(react-cap-theme): fix border styles for field :focus states #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvdzkwsk merged 2 commits into from
Jun 25, 2026
Merged

fix(react-cap-theme): fix border styles for field :focus states #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59e85ef
Fix border styles for field :focus states
dvdzkwsk Jun 24, 2026
667cc0b
Simplify fieldRadius doc comment
dvdzkwsk Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-contrib-react-cap-theme-5bafc5c8-0ee9-46a6-b17a-969570d427e3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix border styles for field :focus states",
"packageName": "@fluentui-contrib/react-cap-theme",
"email": "6439050+davezuko@users.noreply.github.com",
"dependentChangeType": "patch"
}
20 changes: 17 additions & 3 deletions packages/react-cap-theme/src/facets/rounded-corners/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,13 +178,27 @@ const useSplitButtonRadiusStyles = (
return state;
};

// Rounds a field's corners. A field's focus border is a separate `::after`
// element, so it has to be rounded to match — otherwise it bleeds past the
// corners on focus. Always go through this helper so the two stay in sync.
// (The `height` is Fluent's: it sizes the element to the radius so the corner
// can render before `clipPath` trims the element to the visible 2px line.)
const fieldRadius = (radius: string): GriffelStyle => ({
borderRadius: radius,
'::after': {
height: `max(2px, ${radius})`,

@sxsx1xsxs sxsx1xsxs Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be 2px+radius?

@sxsx1xsxs sxsx1xsxs Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nvm!

borderBottomLeftRadius: radius,
borderBottomRightRadius: radius,
},
});

// Input/Combobox/Dropdown share the same radius behaviour:
// base 2XLarge, small XLarge, and a flat (none) radius for the underline
// appearance (both while editable and while disabled).
const useFieldRadius = makeStyles({
base: { borderRadius: CAP_BORDER_RADII.xxLarge },
small: { borderRadius: CAP_BORDER_RADII.xLarge },
underline: { borderRadius: CAP_BORDER_RADII.none },
base: fieldRadius(CAP_BORDER_RADII.xxLarge),
small: fieldRadius(CAP_BORDER_RADII.xLarge),
underline: fieldRadius(CAP_BORDER_RADII.none),
});

// The radius is identical (`none`) whether the underline is editable or
Expand Down
Loading