fix(react-cap-theme): declare missing runtime deps#664
Merged
Conversation
react-cap-theme imported 28 external packages (@fluentui/* building blocks, @griffel/react, @fluentui/tokens) but declared none of them, relying on workspace-root hoisting. Published builds therefore failed to resolve those imports under strict installers (e.g. pnpm). - Declare the building-block packages as dependencies and @fluentui/react-icons as a peer, using the umbrella's ranges aligned to the workspace's shared version groups. - Add package.json to lintFilePatterns so @nx/dependency-checks runs for this package and prevents regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tudorpopams
approved these changes
Jul 1, 2026
sxsx1xsxs
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-cap-theme imported 28 packages but declared none of them, so it only worked via workspace hoisting and broke under pnpm.
declared them (griffel/tokens/@FluentUI building blocks as deps, react-icons as peer) and added package.json to the lint patterns so dependency-checks catches this next time.