Skip to content

Commit 196cbea

Browse files
authored
Remove overflow hidden from Button for Win32/Windows (#4087)
* Remove overflow hidden for windows * changeset * Update snapshot * chageset
1 parent 544449d commit 196cbea

4 files changed

Lines changed: 14 additions & 2 deletions

File tree

.changeset/late-rules-think.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@fluentui-react-native/button": patch
3+
---
4+
5+
Remove overflow hidden from FURN button for windows

.changeset/small-spiders-pull.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@fluentui-react-native/tooltip": patch
3+
---
4+
5+
Update snapshot

packages/components/Button/src/Button.styling.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ export const buttonStates: (keyof ButtonTokens)[] = [
3333
'disabled',
3434
];
3535

36+
const applyOverflowHiddenToRoot = Platform.OS === 'ios' || Platform.OS === 'macos';
37+
3638
export const stylingSettings: UseStylingOptions<ButtonProps, ButtonSlotProps, ButtonTokens> = {
3739
tokens: [defaultButtonTokens, defaultButtonFontTokens, defaultButtonColorTokens, buttonName],
3840
states: buttonStates,
@@ -58,7 +60,7 @@ export const stylingSettings: UseStylingOptions<ButtonProps, ButtonSlotProps, Bu
5860
(tokens: ButtonTokens, theme: Theme) => ({
5961
style: {
6062
display: 'flex',
61-
overflow: 'hidden',
63+
overflow: applyOverflowHiddenToRoot ? 'hidden' : undefined,
6264
alignItems: 'center',
6365
flexDirection: 'row',
6466
alignSelf: 'flex-start',

packages/experimental/Tooltip/src/__tests__/__snapshots__/Tooltip.test.tsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ exports[`Tooltip component tests Tooltip default 1`] = `
6666
"justifyContent": "center",
6767
"minHeight": 24,
6868
"minWidth": 64,
69-
"overflow": "hidden",
69+
"overflow": undefined,
7070
"padding": 3,
7171
"paddingHorizontal": 7,
7272
"width": undefined,

0 commit comments

Comments
 (0)