Skip to content

Commit 2f7c365

Browse files
JasonVMoJasonVMo
authored
fix(multi): Packages using the jsx-runtime should have @fluentui-react-native/framework-base as a dependency (#4133)
* move framework-base to be a dependency for packages that use the jsx factory * fix change command on windows and add change file
1 parent 6805bf5 commit 2f7c365

29 files changed

Lines changed: 65 additions & 32 deletions

File tree

‎.changeset/eighty-stamps-stare.md‎

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
---
2+
"@fluentui-react-native/experimental-activity-indicator": patch
3+
"@fluentui-react-native/contextual-menu": patch
4+
"@fluentui-react-native/notification": patch
5+
"@fluentui-react-native/experimental-menu-button": patch
6+
"@fluentui-react-native/persona-coin": patch
7+
"@fluentui-react-native/menu-button": patch
8+
"@fluentui-react-native/radio-group": patch
9+
"@fluentui-react-native/experimental-checkbox": patch
10+
"@fluentui-react-native/dropdown": patch
11+
"@fluentui-react-native/experimental-expander": patch
12+
"@fluentui-react-native/separator": patch
13+
"@fluentui-react-native/popover": patch
14+
"@fluentui-react-native/experimental-shimmer": patch
15+
"@fluentui-react-native/spinner": patch
16+
"@fluentui-react-native/checkbox": patch
17+
"@fluentui-react-native/experimental-avatar": patch
18+
"@fluentui-react-native/drawer": patch
19+
"@fluentui-react-native/divider": patch
20+
"@fluentui-react-native/persona": patch
21+
"@fluentui-react-native/tablist": patch
22+
"@fluentui-react-native/avatar": patch
23+
"@fluentui-react-native/button": patch
24+
"@fluentui-react-native/input": patch
25+
"@fluentui-react-native/stack": patch
26+
"@fluentui-react-native/chip": patch
27+
"@fluentui-react-native/link": patch
28+
"@fluentui-react-native/text": patch
29+
---
30+
31+
Add missing dependency on framework-base

‎.github/scripts/change.mts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22
// @ts-ignore
33
import { parseArgs, styleText } from 'node:util';
44

5-
import { $, echo, fs } from 'zx';
5+
import { $, echo, fs, quote } from 'zx';
6+
7+
$.quote = quote;
68

79
/**
810
* Wrapper around `changeset add` (default) and `changeset status` validation (--check).

‎packages/components/Avatar/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
"@fluentui-react-native/adapters": "workspace:*",
3636
"@fluentui-react-native/badge": "workspace:*",
3737
"@fluentui-react-native/framework": "workspace:*",
38+
"@fluentui-react-native/framework-base": "workspace:*",
3839
"@fluentui-react-native/icon": "workspace:*",
3940
"@fluentui-react-native/theme-tokens": "workspace:*",
4041
"@fluentui-react-native/theming-utils": "workspace:*",
@@ -44,7 +45,6 @@
4445
},
4546
"devDependencies": {
4647
"@babel/core": "catalog:",
47-
"@fluentui-react-native/framework-base": "workspace:*",
4848
"@fluentui-react-native/scripts": "workspace:*",
4949
"@office-iss/react-native-win32": "^0.81.8",
5050
"@react-native-community/cli": "^20.0.0",

‎packages/components/Button/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
"@fluentui-react-native/experimental-activity-indicator": "workspace:*",
3737
"@fluentui-react-native/experimental-shadow": "workspace:*",
3838
"@fluentui-react-native/framework": "workspace:*",
39+
"@fluentui-react-native/framework-base": "workspace:*",
3940
"@fluentui-react-native/icon": "workspace:*",
4041
"@fluentui-react-native/interactive-hooks": "workspace:*",
4142
"@fluentui-react-native/pressable": "workspace:*",
@@ -52,7 +53,6 @@
5253
},
5354
"devDependencies": {
5455
"@babel/core": "catalog:",
55-
"@fluentui-react-native/framework-base": "workspace:*",
5656
"@fluentui-react-native/scripts": "workspace:*",
5757
"@fluentui-react-native/test-tools": "workspace:*",
5858
"@office-iss/react-native-win32": "^0.81.8",

‎packages/components/Checkbox/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"dependencies": {
3535
"@fluentui-react-native/adapters": "workspace:*",
3636
"@fluentui-react-native/framework": "workspace:*",
37+
"@fluentui-react-native/framework-base": "workspace:*",
3738
"@fluentui-react-native/interactive-hooks": "workspace:*",
3839
"@fluentui-react-native/pressable": "workspace:*",
3940
"@fluentui-react-native/styling-utils": "workspace:*",
@@ -48,7 +49,6 @@
4849
},
4950
"devDependencies": {
5051
"@babel/core": "catalog:",
51-
"@fluentui-react-native/framework-base": "workspace:*",
5252
"@fluentui-react-native/scripts": "workspace:*",
5353
"@fluentui-react-native/test-tools": "workspace:*",
5454
"@office-iss/react-native-win32": "^0.81.8",

‎packages/components/Chip/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"dependencies": {
3030
"@fluentui-react-native/adapters": "workspace:*",
3131
"@fluentui-react-native/framework": "workspace:*",
32+
"@fluentui-react-native/framework-base": "workspace:*",
3233
"@fluentui-react-native/icon": "workspace:*",
3334
"@fluentui-react-native/interactive-hooks": "workspace:*",
3435
"@fluentui-react-native/text": "workspace:*",
@@ -37,7 +38,6 @@
3738
},
3839
"devDependencies": {
3940
"@babel/core": "catalog:",
40-
"@fluentui-react-native/framework-base": "workspace:*",
4141
"@fluentui-react-native/scripts": "workspace:*",
4242
"@fluentui-react-native/test-tools": "workspace:*",
4343
"@fluentui-react-native/use-styling": "workspace:*",

‎packages/components/ContextualMenu/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
"@fluentui-react-native/adapters": "workspace:*",
3636
"@fluentui-react-native/callout": "workspace:*",
3737
"@fluentui-react-native/focus-zone": "workspace:*",
38+
"@fluentui-react-native/framework-base": "workspace:*",
3839
"@fluentui-react-native/icon": "workspace:*",
3940
"@fluentui-react-native/interactive-hooks": "workspace:*",
4041
"@fluentui-react-native/text": "workspace:*",
@@ -45,7 +46,6 @@
4546
},
4647
"devDependencies": {
4748
"@babel/core": "catalog:",
48-
"@fluentui-react-native/framework-base": "workspace:*",
4949
"@fluentui-react-native/pressable": "workspace:*",
5050
"@fluentui-react-native/scripts": "workspace:*",
5151
"@office-iss/react-native-win32": "^0.81.8",

‎packages/components/Divider/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@
3232
},
3333
"dependencies": {
3434
"@fluentui-react-native/framework": "workspace:*",
35+
"@fluentui-react-native/framework-base": "workspace:*",
3536
"@fluentui-react-native/icon": "workspace:*",
3637
"@fluentui-react-native/text": "workspace:*",
3738
"@fluentui-react-native/theme-tokens": "workspace:*",
3839
"@fluentui-react-native/tokens": "workspace:*"
3940
},
4041
"devDependencies": {
4142
"@babel/core": "catalog:",
42-
"@fluentui-react-native/framework-base": "workspace:*",
4343
"@fluentui-react-native/scripts": "workspace:*",
4444
"@fluentui-react-native/test-tools": "workspace:*",
4545
"@office-iss/react-native-win32": "^0.81.8",

‎packages/components/Input/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
},
3333
"dependencies": {
3434
"@fluentui-react-native/framework": "workspace:*",
35+
"@fluentui-react-native/framework-base": "workspace:*",
3536
"@fluentui-react-native/icon": "workspace:*",
3637
"@fluentui-react-native/interactive-hooks": "workspace:*",
3738
"@fluentui-react-native/styling-utils": "workspace:*",
@@ -42,7 +43,6 @@
4243
},
4344
"devDependencies": {
4445
"@babel/core": "catalog:",
45-
"@fluentui-react-native/framework-base": "workspace:*",
4646
"@fluentui-react-native/scripts": "workspace:*",
4747
"@fluentui-react-native/test-tools": "workspace:*",
4848
"@react-native-community/cli": "^20.0.0",

‎packages/components/Link/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"dependencies": {
3434
"@fluentui-react-native/adapters": "workspace:*",
3535
"@fluentui-react-native/framework": "workspace:*",
36+
"@fluentui-react-native/framework-base": "workspace:*",
3637
"@fluentui-react-native/interactive-hooks": "workspace:*",
3738
"@fluentui-react-native/text": "workspace:*",
3839
"@fluentui-react-native/tokens": "workspace:*",
@@ -43,7 +44,6 @@
4344
},
4445
"devDependencies": {
4546
"@babel/core": "catalog:",
46-
"@fluentui-react-native/framework-base": "workspace:*",
4747
"@fluentui-react-native/scripts": "workspace:*",
4848
"@fluentui-react-native/test-tools": "workspace:*",
4949
"@react-native-community/cli": "^20.0.0",

0 commit comments

Comments
 (0)