address PR feedback

JasonVMo · JasonVMo · commit 61651e595f9c · 2026-03-02T09:57:15.000-08:00
diff --git a/.changeset/funny-news-smell.md b/.changeset/funny-news-smell.md
@@ -1,13 +1,13 @@
 ---
-"@fluentui-react-native/contextual-menu": patch
-"@fluentui-react-native/vibrancy-view": patch
-"@fluentui-react-native/focus-trap-zone": patch
-"@fluentui-react-native/menu-button": patch
-"@fluentui-react-native/focus-zone": patch
-"@fluentui-react-native/tooltip": patch
-"@fluentui-react-native/experimental-avatar": patch
-"@fluentui-react-native/callout": patch
-"@fluentui-react-native/button": patch
+'@fluentui-react-native/contextual-menu': patch
+'@fluentui-react-native/vibrancy-view': patch
+'@fluentui-react-native/focus-trap-zone': patch
+'@fluentui-react-native/menu-button': patch
+'@fluentui-react-native/focus-zone': patch
+'@fluentui-react-native/tooltip': patch
+'@fluentui-react-native/experimental-avatar': patch
+'@fluentui-react-native/callout': patch
+'@fluentui-react-native/button': patch
 ---
 
 Fix codegen definitions for native components in repo
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -13,9 +13,7 @@
   "prettier.trailingComma": "all",
 
   "eslint.enable": true,
-  "eslint.workingDirectories": [
-    { "pattern": "./packages/framework/eslint-config-rules" }
-  ], // use the common eslint config file
+  "eslint.workingDirectories": [{ "pattern": "./packages/framework/eslint-config-rules" }], // use the common eslint config file
 
   "explorer.fileNesting.enabled": true,
   "explorer.fileNesting.patterns": {
diff --git a/packages/components/Callout/macos/FRNCalloutManager.m b/packages/components/Callout/macos/FRNCalloutManager.m
@@ -29,6 +29,7 @@ + (NSRect)screenRect:(id)json
 	@"rightCenter": @(NSRectEdgeMaxX),
 	@"rightBottomEdge": @(NSRectEdgeMaxX),
 	@"bottomLeftEdge": @(NSRectEdgeMinY),
+  @"bottonLeftEdge": @(NSRectEdgeMinY), // Add both the correct and incorrect spellings during the transition period
 	@"bottomAutoEdge": @(NSRectEdgeMinY),
 	@"bottomCenter": @(NSRectEdgeMinY),
 	@"bottomRightEdge": @(NSRectEdgeMinY),
diff --git a/packages/components/Callout/src/Callout.settings.macos.ts b/packages/components/Callout/src/Callout.settings.macos.ts
@@ -10,7 +10,7 @@ export const settings: IComposeSettings<ICalloutType> = [
       borderColor: 'transparent',
       borderWidth: 0,
       borderRadius: 5,
-      directionalHint: 'bottomLeftEdge',
+      directionalHint: 'bottonLeftEdge',
     },
     root: {
       style: {
diff --git a/packages/components/Callout/src/Callout.settings.ts b/packages/components/Callout/src/Callout.settings.ts
@@ -10,7 +10,7 @@ export const settings: IComposeSettings<ICalloutType> = [
       beakWidth: 20,
       borderColor: 'bodyFrameBackground',
       borderWidth: 1,
-      directionalHint: 'bottomLeftEdge',
+      directionalHint: 'bottonLeftEdge',
       gapSpace: 0,
       minPadding: 0,
     },
diff --git a/packages/components/Callout/src/Callout.types.ts b/packages/components/Callout/src/Callout.types.ts
@@ -24,6 +24,7 @@ export type DirectionalHint =
   | 'rightCenter'
   | 'rightBottomEdge'
   | 'bottomLeftEdge'
+  | 'bottonLeftEdge' // Typo in the original code, should be 'bottomLeftEdge'
   | 'bottomAutoEdge'
   | 'bottomCenter'
   | 'bottomRightEdge';
diff --git a/packages/components/Callout/src/CalloutNativeComponent.macos.ts b/packages/components/Callout/src/CalloutNativeComponent.macos.ts
@@ -46,6 +46,7 @@ export interface NativeProps extends ViewProps {
     | 'rightCenter'
     | 'rightBottomEdge'
     | 'bottomLeftEdge'
+    | 'bottonLeftEdge' // Typo in the original code, should be 'bottomLeftEdge'
     | 'bottomAutoEdge'
     | 'bottomCenter'
     | 'bottomRightEdge',
diff --git a/packages/components/Callout/src/CalloutNativeComponent.ts b/packages/components/Callout/src/CalloutNativeComponent.ts
@@ -46,10 +46,11 @@ export interface NativeProps extends ViewProps {
     | 'rightCenter'
     | 'rightBottomEdge'
     | 'bottomLeftEdge'
+    | 'bottonLeftEdge' // Typo in the original code, should be 'bottomLeftEdge'
     | 'bottomAutoEdge'
     | 'bottomCenter'
     | 'bottomRightEdge',
-    'bottomLeftEdge'
+    'bottonLeftEdge'
   >;
   target?: UnsafeMixed;
 }
diff --git a/packages/components/ContextualMenu/src/ContextualMenu.settings.macos.ts b/packages/components/ContextualMenu/src/ContextualMenu.settings.macos.ts
@@ -8,7 +8,7 @@ import { contextualMenuName } from './ContextualMenu.types';
 export const settings: IComposeSettings<ContextualMenuType> = [
   {
     tokens: {
-      directionalHint: I18nManager.isRTL ? 'bottomRightEdge' : 'bottomLeftEdge',
+      directionalHint: I18nManager.isRTL ? 'bottomRightEdge' : 'bottonLeftEdge',
     },
     container: {
       style: {
diff --git a/packages/components/ContextualMenu/src/ContextualMenu.settings.ts b/packages/components/ContextualMenu/src/ContextualMenu.settings.ts
@@ -10,7 +10,7 @@ export const settings: IComposeSettings<ContextualMenuType> = [
       beakWidth: 20,
       borderColor: 'buttonBorder',
       borderWidth: 1,
-      directionalHint: 'bottomLeftEdge',
+      directionalHint: 'bottonLeftEdge',
       gapSpace: 0,
       minPadding: 0,
     },

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ import { contextualMenuName } from './ContextualMenu.types';`
`8`	`8`	`export const settings: IComposeSettings<ContextualMenuType> = [`
`9`	`9`	`{`
`10`	`10`	`tokens: {`
`11`		`- directionalHint: I18nManager.isRTL ? 'bottomRightEdge' : 'bottomLeftEdge',`
	`11`	`+ directionalHint: I18nManager.isRTL ? 'bottomRightEdge' : 'bottonLeftEdge',`
`12`	`12`	`},`
`13`	`13`	`container: {`
`14`	`14`	`style: {`