Fix PR gate job to fail when upstream jobs fail (#4091)

* Fix PR gate job to fail instead of skip when upstream jobs fail

The `pr` gate job is the only required status check for merging.
Without `if: always()`, when any dependency job fails, the gate job
gets skipped — and GitHub treats skipped as passing, allowing PRs
with failing checks to be merged (e.g. #4087).

This adds `if: always()` so the gate job always runs, and an explicit
check that fails the job when any dependency failed or was cancelled.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* [Testing] break a snapshot

* Update Button.test.tsx.snap

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: Saadnajmi

.github/workflows/pr.yml

@@ -385,6 +385,7 @@ jobs:
 
   pr:
     name: PR
+    if: always()
     runs-on: ubuntu-latest
     needs:
       - js
@@ -398,5 +399,10 @@ jobs:
       - publish-dry-run
       - test-links
     steps:
+      - name: Check for failures or cancellations
+        if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}
+        run: |
+          echo "One or more required jobs failed or were cancelled."
+          exit 1
       - name: All required jobs passed
-        run: echo "All required jobs completed."
+        run: echo "All required jobs completed successfully."