Merged
Conversation
rge branch 'main' of https://github.com/microsoft/fluentui-react-native
rurikoaraki
approved these changes
Apr 21, 2025
Collaborator
|
@samuelfreiberg Guess we should update the versions of the main packages too? |
Contributor
Author
We should - it will most likely be a larger change that requires modifications to our existing testing code. I'll add a task for it to do in a subsequent PR. What version of Node does our CI run on? |
Collaborator
|
Looks like Node 22? #3843 ETA: But maybe that's only for apple |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
WebDriverIO v8 isn't compatible with Nove v22, so we need to upgrade. Once this PR gets merged, it will generate an updated NuGet package that we can then consume the package elsewhere for the testing dependencies.
Once this PR gets merged and the NuGet package is generated, I'm going to make another PR migrating this package to a different, more suitable repo. It doesn't belong in FURN anymore.
Verification
(how the change was tested, including both manual and automated tests)
Pull request checklist
This PR has considered (when applicable):