Skip to content

ContextualMenu A11y Narrator Bug Fix#3905

Merged
gulnazsayed merged 5 commits intomicrosoft:mainfrom
gulnazsayed:a11y-nested-menu
Jun 18, 2025
Merged

ContextualMenu A11y Narrator Bug Fix#3905
gulnazsayed merged 5 commits intomicrosoft:mainfrom
gulnazsayed:a11y-nested-menu

Conversation

@gulnazsayed
Copy link
Copy Markdown
Contributor

@gulnazsayed gulnazsayed commented Jun 16, 2025

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Narrator should announce whether a ContextualMenu SubmenuItem is expanded or collapsed. According to accessibility guidelines, we need to specify accessibilityActions and onAccessibilityAction, as well as provide the expanded state in accessibilityState. To avoid extra overhead in SubmenuItem, I extended from PressablePropsExtended instead of IPressableProps to inherit all of the necessary accessibility props and follow the pattern found in other V1 components. Then, provided the default accessibilityActions to be merged with any custom actions the user might pass in.

Verification

Manually validated via the FURN tester that narrator announces the expanded/collapsed state of a nested submenu item when focused.

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@gulnazsayed gulnazsayed requested review from Dewsk and rurikoaraki June 16, 2025 23:07
@gulnazsayed gulnazsayed requested a review from a team as a code owner June 16, 2025 23:07
@gulnazsayed gulnazsayed changed the title ContextualMenu A11y Narrator Bug Fix - Narrator should announce nested submenu item expanded/collapsed state ContextualMenu A11y Narrator Bug Fix Jun 16, 2025
@gulnazsayed gulnazsayed enabled auto-merge (squash) June 17, 2025 18:11
@gulnazsayed gulnazsayed merged commit fc21bff into microsoft:main Jun 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants