fix(assets): remove '* Temp (LTR|RTL)' staging folders to restore build determinism#1087
Merged
Merged
Conversation
📋 PR Validation SummaryCheck the Build react library job summary for detailed reports:
|
9e60bbc to
47b74b6
Compare
etudie
approved these changes
May 21, 2026
etudie
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the bump, missed this PR!
Noting your rebase comment.
Looks good!
47b74b6 to
a32aad4
Compare
…llowlist These 20 folders were staging artifacts that caused non-deterministic React atom/font output via filename collisions in importer/generate.js (see microsoft#1086). They contain SVGs named after the OPPOSITE icon (e.g. 'Arrow Undo Temp RTL/ SVG/ic_fluent_arrow_redo_*.svg'), have no metadata.json, and are not consumed by any active pipeline. With the folders gone, the KNOWN_DUPLICATE_SOURCE allowlist in importer/generate.js is also removed; the default --on-duplicate=fail now guards against any new colliding asset folders. Verified: two clean 'nx run react-icons:build' runs after this change produce byte-identical lib/, lib-cjs/, and metadata.json. Follow-up to microsoft#1086.
a32aad4 to
74c6575
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1086 — must merge after that PR.
Removes the 20
assets/* Temp (LTR|RTL)/folders flagged as known-dirty by the detector introduced in #1086, and drops the matchingKNOWN_DUPLICATE_SOURCEallowlist fromimporter/generate.js. With the allowlist gone, the default--on-duplicate=failnow guards against any new colliding asset folder being added.Why
These folders contain SVGs named after the opposite icon (e.g.
assets/Arrow Undo Temp RTL/SVG/ic_fluent_arrow_redo_*.svg), have nometadata.json, and write into the same flatintermediate/filenames as the canonical asset folders. The async copy ingenerate.jsthen resolves the collision non-deterministically, producing differentlib/atoms/svg/*.js, barrel chunks, and font binaries on each clean build. #1086 added a detector + temporary allowlist for them; this PR removes the underlying source data and the allowlist.Folders removed (20, 272 files total)
assets/Arrow Redo Temp LTR/,assets/Arrow Redo Temp RTL/assets/Arrow Undo Temp LTR/,assets/Arrow Undo Temp RTL/assets/Table Freeze Column Temp LTR/,assets/Table Freeze Column Temp RTL/assets/Table Freeze Column And Row Temp LTR/,assets/Table Freeze Column And Row Temp RTL/assets/Text Align Left Temp LTR/,assets/Text Align Left Temp RTL/assets/Text First Line Temp LTR/,assets/Text First Line Temp RTL/assets/Text Grammar Arrow Left Temp LTR/,assets/Text Grammar Arrow Left Temp RTL/assets/Text Grammar Arrow Right Temp LTR/,assets/Text Grammar Arrow Right Temp RTL/assets/Text Hanging Temp LTR/,assets/Text Hanging Temp RTL/assets/Text Paragraph Temp LTR/,assets/Text Paragraph Temp RTL/Each folder contained only
PDF/andSVG/subdirectories with.pdf/.svgfiles — nometadata.jsonor other tracked files.Verification
node importer/generate.js … --target=react --on-duplicate=failon fullassets/nx run react-icons:buildruns →diff -rq lib/ lib-cjs/ metadata.jsonOut of scope
mainvia feat(importer): detect duplicate destination filenames in generate.js #1086)Temp (LTR|RTL)onesReviewer checklist
monosize.baseline.jsondoesn't need updating (no React icon export changes expected — canonical folders already provide the same names)Stack note
This PR's diff against
maincurrently includes the commit from #1086 (a4427400a2). Once #1086 merges, this PR will rebase automatically and show only the cleanup commit.