[fix]: Hitting escape once should close alert dialog (#34382)

Author: eljefe223

change/@fluentui-web-components-4d430b96-9653-4166-8f37-1be12ad9cfb8.json

@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "[fix]: Hitting escape once should close alert dialog",
+  "packageName": "@fluentui/web-components",
+  "email": "jes@microsoft.com",
+  "dependentChangeType": "patch"
+}

packages/web-components/src/dialog/dialog.spec.ts

@@ -154,26 +154,6 @@ test.describe('Dialog', () => {
     await expect(content).toBeVisible();
   });
 
-  test('should NOT close after the escape key is pressed when its `type` attribute is set to "alert"', async ({
-    fastPage,
-    page,
-  }) => {
-    const { element } = fastPage;
-    const content = element.locator('#content');
-
-    await fastPage.setTemplate({ attributes: { type: 'alert' } });
-
-    await element.evaluate((node: Dialog) => {
-      node.show();
-    });
-
-    await expect(content).toBeVisible();
-
-    await page.keyboard.press('Escape');
-
-    await expect(content).toBeVisible();
-  });
-
   test('should set the `role` attribute to "dialog" on the internal dialog element when the `type` attribute is set to "dialog"', async ({
     fastPage,
   }) => {

packages/web-components/src/dialog/dialog.template.ts

@@ -17,7 +17,7 @@ export const template: ElementViewTemplate<Dialog> = html`
     aria-labelledby="${x => x.ariaLabelledby}"
     aria-label="${x => x.ariaLabel}"
     @click="${(x, c) => x.clickHandler(c.event as MouseEvent)}"
-    @cancel="${(x, c) => (x.type === DialogType.alert ? c.event.preventDefault() : x.hide())}"
+    @cancel="${x => x.hide()}"
     ${ref('dialog')}
   >
     <slot></slot>