refactor(react-popover): remove isolated unit tests for getPopoverSurfaceAriaAttributes

- Remove isolated unit tests for getPopoverSurfaceAriaAttributes function
- Keep component-level integration tests that verify aria attributes through rendered component
- Update function comment to remove mention of isolated testing
- Component logic is now tested as a whole rather than in isolation

Author: PaulGMardling

packages/react-components/react-popover/library/src/components/PopoverSurface/PopoverSurface.test.tsx

@@ -1,7 +1,6 @@
 import { resetIdsForTests } from '@fluentui/react-utilities';
 import * as React from 'react';
 import { PopoverSurface } from './PopoverSurface';
-import { getPopoverSurfaceAriaAttributes } from './usePopoverSurface';
 import { render, fireEvent } from '@testing-library/react';
 import { isConformant } from '../../testing/isConformant';
 import { mockPopoverContext } from '../../testing/mockUsePopoverContext';
@@ -83,37 +82,3 @@ describe('PopoverSurface', () => {
     expect(getByTestId(testid).getAttribute('role')).toEqual('group');
   });
 });
-
-describe('getPopoverSurfaceAriaAttributes', () => {
-  it('returns dialog attributes when focus is trapped', () => {
-    expect(
-      getPopoverSurfaceAriaAttributes({
-        hasAccessibleName: false,
-        trapFocus: true,
-      }),
-    ).toEqual({
-      role: 'dialog',
-      'aria-modal': true,
-    });
-  });
-
-  it('returns group when the surface has an accessible name', () => {
-    expect(
-      getPopoverSurfaceAriaAttributes({
-        hasAccessibleName: true,
-        trapFocus: false,
-      }),
-    ).toEqual({
-      role: 'group',
-    });
-  });
-
-  it('returns no role when the surface is unlabelled', () => {
-    expect(
-      getPopoverSurfaceAriaAttributes({
-        hasAccessibleName: false,
-        trapFocus: false,
-      }),
-    ).toEqual({});
-  });
-});

packages/react-components/react-popover/library/src/components/PopoverSurface/usePopoverSurface.ts

@@ -12,7 +12,6 @@ type PopoverSurfaceAriaAttributes = Pick<React.HTMLAttributes<HTMLDivElement>, '
 /**
  * Returns the ARIA role and modal attributes for a PopoverSurface.
  *
- * Extracted as a pure function to allow isolated unit testing of the attribute logic.
  * - `trapFocus=true` → `role="dialog"` + `aria-modal=true`
  * - `trapFocus=false` + accessible name present → `role="group"`
  * - `trapFocus=false` + no accessible name → no role (plain div avoids screen reader