make sure disabled menu items are focusable but not participating in directional navigation

marchbox · marchbox · commit c6832d23afad · 2026-03-30T14:27:27.000-07:00
diff --git a/packages/web-components/src/menu-list/menu-list.ts b/packages/web-components/src/menu-list/menu-list.ts
@@ -123,9 +123,7 @@ export class MenuList extends FASTElement {
 
     this.menuItems?.forEach((item: HTMLElement) => {
       item.dataset.indent = `${indent}`;
-      if (!item.hasAttribute('disabled')) {
-        item.tabIndex = 0;
-      }
+      item.tabIndex = item.hasAttribute('disabled') ? -1 : 0;
     });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -123,9 +123,7 @@ export class MenuList extends FASTElement {`
`123`	`123`
`124`	`124`	`this.menuItems?.forEach((item: HTMLElement) => {`
`125`	`125`	item.dataset.indent = `${indent}`;
`126`		`- if (!item.hasAttribute('disabled')) {`
`127`		`- item.tabIndex = 0;`
`128`		`- }`
	`126`	`+ item.tabIndex = item.hasAttribute('disabled') ? -1 : 0;`
`129`	`127`	`});`
`130`	`128`	`}`
`131`	`129`