chore: migrate to yarn modern#35747
Open
mainframev wants to merge 11 commits into
Open
Conversation
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
from
February 12, 2026 15:33
479d2cd to
df4487b
Compare
📊 Bundle size report
Unchanged fixtures
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
4 times, most recently
from
February 16, 2026 20:37
7bdc1bc to
6b5f740
Compare
|
Pull request demo site: URL |
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
10 times, most recently
from
February 17, 2026 10:42
5e16b71 to
b40e143
Compare
mainframev
commented
Feb 18, 2026
| "packages/*", | ||
| "packages/react-components/*", | ||
| "packages/react-components/*/*", | ||
| "!packages/react-components/react-jsx-runtime/jsx-runtime", |
Contributor
Author
There was a problem hiding this comment.
Yarn classic was silently skipping directories without name in package.json files, Yarn modern is more stricter and we need to exclude these sub paths explicitly
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
from
February 18, 2026 15:31
1435cc5 to
1e47bea
Compare
mainframev
commented
Feb 18, 2026
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
from
February 18, 2026 16:06
f891481 to
4aff9a8
Compare
mainframev
commented
Feb 18, 2026
| "bin": { | ||
| "storybook-llms-extractor": "./bin/storybook-llms-extractor.js" | ||
| }, | ||
| "bin": "./bin/storybook-llms-extractor.js", |
Contributor
Author
There was a problem hiding this comment.
yarn automatically makes bin as shorthand and removes empty peerDependencies
Contributor
There was a problem hiding this comment.
this is a public package actively used, do we need to make this change ? I'd suggest to revert
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
from
February 20, 2026 13:54
a827a55 to
7adf9fc
Compare
mainframev
requested review from
a team,
Jacqueline-ms and
Jahnp
as code owners
March 24, 2026 05:24
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
from
April 7, 2026 14:10
1d16cf3 to
38b5630
Compare
layershifter
reviewed
Apr 7, 2026
layershifter
reviewed
Apr 7, 2026
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
2 times, most recently
from
May 25, 2026 15:37
891eb69 to
9413197
Compare
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
from
June 5, 2026 14:43
9413197 to
fcfbda8
Compare
…yarn run -T The migration makes inferred targets exec via 'yarn run -T'; the react-compiler-analyzer target-group inline snapshots still expected the old 'yarn <bin>' form.
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
from
July 17, 2026 10:14
7f2a050 to
84b6b0d
Compare
AtishayMsft
approved these changes
Jul 17, 2026
mainframev
force-pushed
the
chore/migrate-to-yarn-modern-core
branch
from
July 17, 2026 12:43
1d0a7fe to
97be392
Compare
Hotell
reviewed
Jul 17, 2026
| index 84d6ced..4512f06 100644 | ||
| --- a/node_modules/@typescript-eslint/eslint-plugin/dist/rules/no-deprecated.js | ||
| +++ b/node_modules/@typescript-eslint/eslint-plugin/dist/rules/no-deprecated.js | ||
| diff --git a/dist/rules/no-deprecated.js b/dist/rules/no-deprecated.js |
Contributor
There was a problem hiding this comment.
@mainframev didnt this already ship in the official package ? please check as a follow up so we can go clean
| "test": "jest --passWithNoTests" | ||
| }, | ||
| "dependencies": { | ||
| "@fluentui/react": "*", |
Contributor
There was a problem hiding this comment.
was all this churn necessary ?
| await shEcho(`yarn --version`); | ||
| await shEcho(`yarn tsc --version`); | ||
| await shEcho(`yarn tsc --version`, tempPaths.testApp); | ||
| await shEcho(`yarn run -T tsc --version`); |
Contributor
There was a problem hiding this comment.
why do we need run -T here ? this bootstraps its separate project with only 1 typescript versions
| @@ -1,5 +1,3 @@ | |||
| // @ts-check | |||
Contributor
There was a problem hiding this comment.
revert pls if not justified change
| yarnPath: .yarn/releases/yarn-4.12.0.cjs | ||
|
|
||
| logFilters: | ||
| - code: YN0002 |
Contributor
There was a problem hiding this comment.
What’s the rationale for globally discarding YN0002 here? Since that warning covers missing peer dependencies, suppressing it repo-wide could hide real dependency issues during the Yarn 4 migration.
| "bin": { | ||
| "storybook-llms-extractor": "./bin/storybook-llms-extractor.js" | ||
| }, | ||
| "bin": "./bin/storybook-llms-extractor.js", |
Contributor
There was a problem hiding this comment.
this is a public package actively used, do we need to make this change ? I'd suggest to revert
| "bin": { | ||
| "visual-regression-assert": "./bin/visual-regression-assert.js" | ||
| }, | ||
| "bin": "./bin/visual-regression-assert.js", |
Contributor
There was a problem hiding this comment.
is this needed for migration ?
| projectConfigGlob, | ||
| async (configFiles, options, context) => { | ||
| const globalConfig: Pick<TaskBuilderConfig, 'pmc'> = { pmc: getPackageManagerCommand('yarn') }; | ||
| const pmc = getPackageManagerCommand('yarn'); |
Contributor
There was a problem hiding this comment.
nx getPackageManagerCommand doesn't provide what we need here ? if not this makes it coupled for yarn in our repo ( not a blocker ) but we need to double check, if this will be mitigated by nx bump or what's the guidance here
| const config = { | ||
| pmc: { | ||
| ...pmc, | ||
| exec: 'yarn run -TB', |
Contributor
There was a problem hiding this comment.
lets be consistent and remove the B
Suggested change
| exec: 'yarn run -TB', | |
| exec: 'yarn run -T', |
| ); | ||
| " | ||
| `); | ||
| }); |
Contributor
There was a problem hiding this comment.
is this needed as part of migration ?
Contributor
|
additional things to change / verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated FluentUI monorepo from Yarn Classic (v3 bundled CLI) to Yarn Modern (Berry v4.12.0) using nodeLinker: node-modules for full compatibility. No PnP - traditional node_modules/ structure is preserved.
Previous Behavior
Yarn v1
New Behavior
Yarn v4
Yarn binary & configuration
Scripts: just-scripts build → yarn run -T just-scripts build
Resolutions
Syntax change: modern yarn doesn't preserve **/parent/child glob resolutions in practice (strips them during yarn install), so security overrides were flattened from master's scoped form.