fix(web-components): build package before running e2e tests#36257
Merged
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
marchbox
approved these changes
May 27, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
radium-v
force-pushed
the
wc-build-before-e2e
branch
from
27db0fc to
7b67b4d
Compare
davatron5000
approved these changes
May 27, 2026
… token generation step" This reverts commit be5f202.
radium-v
force-pushed
the
wc-build-before-e2e
branch
from
b022c8c to
a378d03
Compare
tudorpopams
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The Nx
e2etarget for@fluentui/web-componentshad nodependsOnentry, sonx run web-components:e2eran against whatever was already indist/from a prior build, or failed on a clean checkout. Token generation also ran in two places:scripts/compile.jsrunsgenerate-tokensduringbuild, andscripts/e2e.jsran it again before invoking Playwright.New Behavior
The Nx
e2etarget declaresdependsOn: ["build"], so Playwright always runs against a freshly built package. The redundantgenerate-tokenscall is removed fromscripts/e2e.jssince tokens are now produced once as a build artifact.