fix: Escape in an open Combobox or Dropdown does not trigger tabster actions#36275
Merged
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
smhigley
force-pushed
the
combobox-tabster-esc
branch
from
5e842b7 to
96f0e0b
Compare
bsunderhus
approved these changes
Jun 12, 2026
layershifter
added a commit
to layershifter/office-ui-fabric-react
that referenced
this pull request
Jun 16, 2026
A Menu nested in a tabster groupper/modalizer (e.g. a focusMode Card, or the Teams chat message reaction popover) moves focus to the groupper root when Escape closes the menu, instead of restoring focus to the trigger. The MenuPopover keydown handler calls event.preventDefault() (and intends to stop propagation), but tabster listens for keydown in the capture phase on the document, so neither prevents tabster's own Escape behaviour from escaping the parent groupper. This is the same problem fixed for react-combobox in microsoft#36275. Fix: add the tabster `focusable.ignoreKeydown: { Escape }` attribute on the MenuPopover, gated on the menu being open, so tabster ignores Escape while the menu handles it (and Escape still works normally when the menu is closed). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
layershifter
added a commit
to layershifter/office-ui-fabric-react
that referenced
this pull request
Jun 16, 2026
A Menu nested in a tabster groupper/modalizer (e.g. a focusMode Card, or a list item whose actions popover shares a modalizer scope with the item) moves focus to the groupper root when Escape closes the menu, instead of restoring focus to the trigger. The MenuPopover keydown handler calls event.preventDefault(), but tabster listens for keydown in the capture phase on the document, so it can't be stopped from the popover handler and still runs its own Escape behaviour (escaping the parent groupper). This is the same problem fixed for react-combobox in microsoft#36275. Fix: add the tabster `focusable.ignoreKeydown: { Escape: true }` attribute on the MenuPopover. The popover only renders while the menu is open, so the attribute is only ever present on an open menu (and Escape still works normally elsewhere) — no need to gate it on the open state. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Escape had
event.stopPropagation, but since tabster listens to the capture phase on the document, that doesn't prevent tabster escape behavior from running. So for e.g. a Combobox in a Card with focusMode, closing the combo would also move focus to the Card root.New Behavior
Adds the tabster ignoreKeydown attr, conditional on the combo/dropdown being open, so escape will still function when closed (standard behavior for selects and popovers, etc.)
Related Issue(s)