refactor: clean up unused variables and improve type safety across multiple files

Author: pelikhan

packages/runtime/src/runtime.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unused-expressions */
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
@@ -431,4 +432,3 @@ export async function fileTree(
       .join("");
   }
 }
-

packages/vscode/src/chatparticipant.ts

@@ -17,7 +17,6 @@ import { convertAnnotationsToItems } from "../../core/src/annotations";
 import { patchCachedImages } from "../../core/src/filecache";
 import { deleteUndefinedValues } from "../../core/src/cleaners";
 
-
 export async function activateChatParticipant(state: ExtensionState) {
   const { context } = state;
   const { subscriptions } = context;
@@ -47,7 +46,8 @@ export async function activateChatParticipant(state: ExtensionState) {
       response: vscode.ChatResponseStream,
       token: vscode.CancellationToken,
     ) => {
-      let { command, prompt, references, model } = request;
+      const { command, references, model } = request;
+      let { prompt } = request;
 
       const md = (t: string, ...enabledCommands: string[]) => {
         const ms = new vscode.MarkdownString(t + "\n", true);

packages/vscode/src/commands.ts

@@ -5,8 +5,8 @@ import * as vscode from "vscode";
 import { TOOL_NAME } from "../../core/src/constants";
 import { errorMessage } from "../../core/src/error";
 
-export function registerCommand(id: string, command: (...args: any[]) => Thenable<void>) {
-  return vscode.commands.registerCommand(id, async function (...args: any[]) {
+export function registerCommand(id: string, command: (...args: unknown[]) => Thenable<void>) {
+  return vscode.commands.registerCommand(id, async function (...args: unknown[]) {
     try {
       await command(...args);
     } catch (e) {

packages/vscode/src/docsnotebook.ts

@@ -60,7 +60,7 @@ interface NotebookFrontMatter {
   smallModel?: string;
   visionModel?: string;
   provider?: ModelProviderType;
-  vars?: Record<string, any>;
+  vars?: PromptParameters;
   files?: string | string[];
 }
 
@@ -120,7 +120,7 @@ function activateNotebookExecutor(state: ExtensionState) {
         const fragment: Fragment = {
           files: arrayify(files),
         };
-        const parameters = { ...heap, ...vars };
+        const parameters: PromptParameters = { ...heap, ...vars };
         await state.requestAI({
           scriptId: template.id,
           label: "Executing cell",
@@ -206,7 +206,7 @@ function activateNotebookSerializer(state: ExtensionState) {
   const deserializeNotebook: (
     data: Uint8Array,
     token: vscode.CancellationToken,
-  ) => vscode.NotebookData = (data, token) => {
+  ) => vscode.NotebookData = (data) => {
     const decoder = new TextDecoder();
     const content = decoder.decode(data);
     const cellRawData = parseMarkdown(content);
@@ -243,10 +243,7 @@ function activateNotebookSerializer(state: ExtensionState) {
       NOTEBOOK_TYPE,
       {
         deserializeNotebook,
-        serializeNotebook: function (
-          data: vscode.NotebookData,
-          token: vscode.CancellationToken,
-        ): Uint8Array {
+        serializeNotebook: function (data: vscode.NotebookData): Uint8Array {
           const encoder = new TextEncoder();
           const decoder = new TextDecoder();
           const { cells } = data;

packages/vscode/src/fs.ts

@@ -25,7 +25,7 @@ export async function checkDirectoryExists(
     const file = filePath ? vscode.Uri.joinPath(folderOrFile, filePath) : folderOrFile;
     const stat = await vscode.workspace.fs.stat(file);
     return stat.type === vscode.FileType.Directory;
-  } catch (error) {
+  } catch {
     return false;
   }
 }
@@ -38,7 +38,7 @@ export async function checkFileExists(
     const file = filePath ? vscode.Uri.joinPath(folderOrFile, filePath) : folderOrFile;
     const stat = await vscode.workspace.fs.stat(file);
     return stat.type === vscode.FileType.File;
-  } catch (error) {
+  } catch {
     return false;
   }
 }
@@ -83,7 +83,7 @@ export async function readFileJSON<T>(
   const src = await readFileText(folder, filePath);
   try {
     return JSON5TryParse(src);
-  } catch (e) {
+  } catch {
     return undefined;
   }
 }

packages/vscode/src/lmaccess.ts

@@ -1,7 +1,6 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-/* eslint-disable @typescript-eslint/naming-convention */
 import * as vscode from "vscode";
 import { ExtensionState } from "./state";
 import type { ChatCompletionMessageParam } from "../../core/src/chattypes";
@@ -65,7 +64,10 @@ async function messagesToChatMessages(messages: ChatCompletionMessageParam[]) {
       case "assistant":
         if (
           Array.isArray(m.content) &&
-          m.content.some((c: any) => typeof c === "object" && "type" in c && c.type === "image_url")
+          m.content.some(
+            (c: ChatCompletionMessageParam["content"][0]) =>
+              typeof c === "object" && "type" in c && c.type === "image_url",
+          )
         )
           throw new Error("Vision model not supported");
         res.push(
@@ -109,9 +111,7 @@ export function createChatModelRunner(state: ExtensionState): LanguageModelChatR
         token,
       );
 
-      let text = "";
       for await (const fragment of request.text) {
-        text += fragment;
         onChunk({
           chunk: fragment,
           tokens: await chatModel.countTokens(fragment),

packages/vscode/src/markdowndocumentprovider.ts

@@ -54,10 +54,7 @@ class MarkdownTextDocumentContentProvider implements vscode.TextDocumentContentP
     return renderTraceTree(node, 3);
   }
 
-  async provideTextDocumentContent(
-    uri: vscode.Uri,
-    token: vscode.CancellationToken,
-  ): Promise<string> {
+  async provideTextDocumentContent(uri: vscode.Uri): Promise<string> {
     const aiRequest = this.state.aiRequest;
     const computing = !!aiRequest?.computing;
     const res = aiRequest?.response;

packages/vscode/src/promptcommands.ts

@@ -113,7 +113,7 @@ export function commandButtons(state: ExtensionState) {
 
 export function commandButtonsMarkdown(state: ExtensionState, sep = " | ") {
   const res = commandButtons(state)
-    .map(({ label, description, cmd }) => `[${label}](command:${cmd})`)
+    .map(({ label, cmd }) => `[${label}](command:${cmd})`)
     .join(sep);
   return res;
 }

packages/vscode/src/prompttree.ts

@@ -34,9 +34,13 @@ class PromptTreeDataProvider implements vscode.TreeDataProvider<PromptTreeNode>
         filename,
         title,
         description = "",
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         system = [],
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         text,
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         defTools,
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
         jsSource,
         ...rest
       } = element;

packages/vscode/src/servermanager.ts

@@ -163,6 +163,7 @@ export class TerminalServerManager extends EventTarget implements ServerManager
 
   private clearTerminalStartWatcher() {
     if (this._terminalStartWatcher) {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       clearTimeout(this._terminalStartWatcher as any);
       this._terminalStartWatcher = undefined;
     }