gitk: check main window visibility before waiting for it to show (#705)

dscho · dscho · commit fff2fe37966d · 2024-12-19T16:09:23.000+01:00
If the main window is already visible when gitk waits for it to become visible, gitk hangs forever. This commit adds a check whether the window is already visible. See https://wiki.tcl-lang.org/page/tkwait+visibility This ports git#944 to `microsoft/git`. for Git. Fixed issue #704.
diff --git a/gitk-git/gitk b/gitk-git/gitk
@@ -12832,7 +12832,7 @@ if {$::tcl_platform(platform) eq {windows} && [file exists $gitk_prefix/etc/git.
     }
 }
 # wait for the window to become visible
-tkwait visibility .
+if {![winfo viewable .]} {tkwait visibility .}
 set_window_title
 update
 readrefs

Original file line number	Diff line number	Diff line change
`@@ -12832,7 +12832,7 @@ if {$::tcl_platform(platform) eq {windows} && [file exists $gitk_prefix/etc/git.`
`12832`	`12832`	`}`
`12833`	`12833`	`}`
`12834`	`12834`	`# wait for the window to become visible`
`12835`		`-tkwait visibility .`
	`12835`	`+if {![winfo viewable .]} {tkwait visibility .}`
`12836`	`12836`	`set_window_title`
`12837`	`12837`	`update`
`12838`	`12838`	`readrefs`