More release script fixes#959
Merged
Merged
Conversation
Without this fix, this shell script does not run in Dash (because it complains that `$1` is not set). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Without this fix, this shell script does not run in Dash (because it complains that `$1` is not set). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Without this fix, this shell script does not run in Dash (because it complains that `$1` is not set). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Changes made by AI may be incorrect, they said. Well, I did miss this because I assumed that the diff was bogus as usual but the change would be sound. Turns out that it really was a bogus change. It was supposed to remove the "extra spaces", which it did. And then it also removed the `case` and the `die` lines for good measure, too. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Turns out that you cannot use `gh pr create` without providing a PR body. It could be empty, of course, but we can simply refer back to the official release (and thereby add a bit of value). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Before trying to remove the temporary directory, we should ensure that we're not in it: On Windows, you cannot remove the current directory. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
derrickstolee
approved these changes
Jul 16, 2026
mjcheetham
approved these changes
Jul 16, 2026
dscho
added a commit
that referenced
this pull request
Jul 16, 2026
This PR preemptively ports #959 to the `v2.55` train.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After promoting v2.54.0.vfs.0.5 to a full release, I ran the scripts (which were formerly three convenient GitHub workflows, see #952), and they all failed, requiring these here fixes.