Commit f4f6b3c
feat(agents): security-planner SSSC parity (#1642)
## Summary
Brings the `security-planner` agent, its supporting instructions, and
the shared RAI capture-coaching guidance up to the same phase-gate,
state, and question-cadence parity established by the `sssc-planner`
work in PR #1497. Bundles the planner-startup, cadence Rule 5 ordering,
risk-grid grammar, and state-schema test suites that guard those
conventions going forward.
## Stacking
- **Base:** `stack/security-state-schema` (PR #1638, "PR A")
- **Upstream:** PR #1497 (sssc-planner)
- **Siblings:** PR #1639 (PR C — Disclaimer/Attribution Protocol), PR
#1640 (PR D)
- **Do not merge** until the PR #1497 → PR #1638 cascade completes.
## Changes
**Modified (10):**
- `.github/agents/security/security-planner.agent.md`
- `.github/instructions/security/identity.instructions.md`
- `.github/instructions/security/security-model.instructions.md`
- `.github/instructions/security/backlog-handoff.instructions.md`
-
`.github/instructions/rai-planning/rai-capture-coaching.instructions.md`
- `.github/prompts/security/security-capture.prompt.md`
- `.github/prompts/security/security-plan-from-prd.prompt.md`
- `plugins/hve-core-all/README.md` (auto-regen)
- `plugins/project-planning/README.md` (auto-regen)
- `plugins/security/README.md` (auto-regen)
**Added (5 Pester suites):**
- `scripts/tests/linting/Test-PlannerStateSchema.Tests.ps1` — 8 tests
- `scripts/tests/linting/Test-PlannerStateSchemas.Tests.ps1` — 4 tests
- `scripts/tests/linting/Test-CadenceRule5Ordering.Tests.ps1` — 2 tests
- `scripts/tests/linting/Test-PlannerStartupBlocks.Tests.ps1` — 6 tests
- `scripts/tests/linting/Test-RiskGridGrammar.Tests.ps1` — 7 tests
## Validation
| Check | Result |
| --- | --- |
| `npm run plugin:validate` | ✅ 13 collections |
| `npm run lint:md` | ✅ 211 files, 0 errors |
| `npm run lint:frontmatter` | ✅ 541 files, 0 errors |
| `npm run lint:md-links` | ✅ |
| `npm run lint:ps` | ✅ |
| `Test-PlannerStateSchema` | ✅ 8/8 |
| `Test-PlannerStateSchemas` | ✅ 4/4 |
| `Test-CadenceRule5Ordering` | ✅ 2/2 |
| `Test-PlannerStartupBlocks` | ✅ 6/6 |
| `Test-RiskGridGrammar` | ✅ 7/7 |
## Notes for Reviewers
1. **`disclaimerShownAt: null` in identity state schema** — Adds one
line to the inline state schema in `identity.instructions.md` so the
canonical state shape declares the field with a default. Full
Disclaimer/Attribution Protocol prose that consumes the field remains in
PR C (#1639). Three-way overlap with PR #1639 on this file is expected.
2. **`Test-PlannerStateSchemas.Tests.ps1` assertion direction** —
Authored draft used `Should -Not -Contain 'disclaimerShownAt'` against
the `required` arrays. Per plan decision DD-06/ID-02
(`.copilot-tracking/plans/2026-05-22/stacked-prs-from-pr-1497-plan.instructions.md`
line 41), the snapshot demotion of
`disclaimerShownAt`/`signingManifestPath` from `required` was **rejected
for uniformity** across `security-state`, `rai-state`, and `sssc-state`
schemas. Flipped both assertions to `Should -Contain` so the test now
affirms the documented uniformity decision. Schemas themselves are
unchanged.
3. **Auto-regenerated plugin READMEs** —
`plugins/hve-core-all/README.md`, `plugins/project-planning/README.md`,
and `plugins/security/README.md` reflect descriptive SSSC text drift
produced by `npm run plugin:generate`. Benign; produced by tooling.
4. **Sandbox/environment note** — All Pester suites and
pwsh-yaml-dependent lints (`plugin:generate`, `plugin:validate`,
`lint:frontmatter`, `lint:md-links`, `lint:ps`) require unsandboxed
execution because the `PowerShell-Yaml` module is installed under
`~/.local/share/powershell/Modules`.
## Merge Order
This PR is part of a 5-PR stack split from PR #1497. Merge in this
order:
1. **#1638** — `feat(scripts): security-planner state schema` (base)
2. **#1639** — `feat(prompts): RAI disclaimer/attribution protocol`
(independent of B, but lands before B for review continuity)
3. **#1642** (this PR) — `feat(agents): security-planner SSSC parity`
(depends on #1638)
Independent of the above sequence:
- **#1640** — `feat(scripts): risk-grid grammar enforcement` (no shared
files)
- **#1641** — `chore(plugins): regenerated plugin READMEs` (tooling
output only)
After #1638 and #1639 merge, rebase this branch onto `main` before
merging.
---------
Signed-off-by: williamberryiii <wberry@microsoft.com>
Co-authored-by: Bill Berry <wbery@microsoft.com>1 parent f8a782b commit f4f6b3c
24 files changed
Lines changed: 431 additions & 164 deletions
File tree
- .github
- agents/security
- instructions
- rai-planning
- security
- prompts/security
- scripts
- linting/schemas
- tests
- fixtures/security-state
- linting
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| 61 | + | |
| 62 | + | |
61 | 63 | | |
62 | 64 | | |
63 | | - | |
| 65 | + | |
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
67 | 69 | | |
68 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
69 | 75 | | |
70 | 76 | | |
71 | 77 | | |
| |||
90 | 96 | | |
91 | 97 | | |
92 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
93 | 107 | | |
94 | 108 | | |
95 | 109 | | |
96 | 110 | | |
97 | | - | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
98 | 126 | | |
99 | | - | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
100 | 131 | | |
101 | | - | |
102 | | - | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
103 | 135 | | |
104 | 136 | | |
105 | 137 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| |||
Lines changed: 18 additions & 121 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
17 | 23 | | |
18 | | - | |
| 24 | + | |
19 | 25 | | |
20 | | - | |
| 26 | + | |
21 | 27 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
27 | 32 | | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
| 198 | + | |
| 199 | + | |
0 commit comments