Skip to content

fix(build): pin tmp >=0.2.6 to resolve GHSA-ph9p-34f9-6g65#1686

Merged
WilliamBerryiii merged 4 commits into
mainfrom
fix/npm-audit-tmp-override
May 29, 2026
Merged

fix(build): pin tmp >=0.2.6 to resolve GHSA-ph9p-34f9-6g65#1686
WilliamBerryiii merged 4 commits into
mainfrom
fix/npm-audit-tmp-override

Conversation

@WilliamBerryiii
Copy link
Copy Markdown
Member

Pull Request

Description

Pin transitive tmp dependency to >=0.2.6 via the root overrides block to resolve GHSA-ph9p-34f9-6g65 (CWE-22 arbitrary path traversal via symbolic link, high severity).

tmp@0.2.5 is pulled in transitively through @vscode/vsce@3.9.1 → tmp. Rather than bumping @vscode/vsce (which could carry unrelated breaking changes), the fix uses the repository's existing overrides pattern alongside other pinned transitive deps (basic-ftp, undici, yauzl, etc.).

Related Issue(s)

Resolves the npm Security Audit CI failure observed on recent PRs (e.g. #1497).

Type of Change

Code & Documentation:

  • Bug fix (non-breaking change fixing an issue)

Infrastructure & Configuration:

  • Security configuration
  • Dependency update

Testing

  • npm install succeeded; package-lock.json regenerated.

  • npm ls tmp --all shows the override is active:

    hve-core@3.3.101
    └─┬ @vscode/vsce@3.9.1
      └── tmp@0.2.6 overridden
    
  • npm run audit:npm (audit-ci) → exit code 0, "Passed npm security audit", 0 vulnerabilities across all severities.

Checklist

Required Checks

  • Files follow existing naming conventions
  • Changes are backwards compatible

Security Considerations

  • This PR does not contain any sensitive or NDA information
  • Any new dependencies have been reviewed for security issues — tmp@0.2.6 is the upstream-published patched release for GHSA-ph9p-34f9-6g65.

- add tmp override in package.json to force @vscode/vsce dep onto patched 0.2.6
- regenerate package-lock.json; npm audit now reports 0 vulnerabilities

🔒 - Generated by Copilot
@WilliamBerryiii WilliamBerryiii requested a review from a team as a code owner May 28, 2026 03:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.55%. Comparing base (5b81056) to head (6440712).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   85.56%   85.55%   -0.01%     
==========================================
  Files          85       85              
  Lines       12396    12396              
==========================================
- Hits        10607    10606       -1     
- Misses       1789     1790       +1     
Flag Coverage Δ
pester 83.88% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot mentioned this pull request May 28, 2026
WilliamBerryiii and others added 2 commits May 28, 2026 17:13
Resolves package-lock.json conflict introduced by main's direct devDep bump (PR #1687). Tightens the tmp override from a range to exact 0.2.7 to match the repo convention of exact pins in the overrides block. GHSA-ph9p-34f9-6g65 remains resolved; npm audit reports 0 vulnerabilities.
@WilliamBerryiii WilliamBerryiii merged commit af67fec into main May 29, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants