fix: fix Nonnull annotation and add unit tests for convertPrimitiveValue

Co-authored-by: baywet <7905502+baywet@users.noreply.github.com>

Author: Copilot

components/serialization/form/src/main/java/com/microsoft/kiota/serialization/FormParseNode.java

@@ -155,7 +155,7 @@ private String sanitizeKey(@Nonnull final String key) {
     }
 
     @SuppressWarnings("unchecked")
-    @Nonnull private static <T> T convertPrimitiveValue(
+    @Nullable private static <T> T convertPrimitiveValue(
             @Nullable final String value, @Nonnull final Class<T> targetClass) {
         if (targetClass == Boolean.class) {
             return (T) parseBooleanValue(value);

components/serialization/form/src/test/java/com/microsoft/kiota/serialization/ParseNodeTests.java

@@ -14,9 +14,12 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 
+import java.math.BigDecimal;
 import java.net.URLEncoder;
 import java.nio.charset.StandardCharsets;
+import java.time.LocalDate;
 import java.time.LocalTime;
+import java.time.OffsetDateTime;
 import java.time.format.DateTimeParseException;
 import java.util.List;
 import java.util.UUID;
@@ -135,4 +138,153 @@ void testInvalidOffsetDateTimeStringThrowsException(final String dateTimeString)
             assertTrue(ex.getMessage().contains(dateTimeString));
         }
     }
+
+    @Test
+    public void getCollectionOfStringPrimitiveValuesFromForm() {
+        final String testFormData = "names=Alice&names=Bob";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("names");
+        final List<String> result = node.getCollectionOfPrimitiveValues(String.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals("Alice", result.get(0));
+        assertEquals("Bob", result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfIntegerPrimitiveValuesFromForm() {
+        final String testFormData = "nums=1&nums=2&nums=3";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("nums");
+        final List<Integer> result = node.getCollectionOfPrimitiveValues(Integer.class);
+        assertNotNull(result);
+        assertEquals(3, result.size());
+        assertEquals(1, result.get(0));
+        assertEquals(2, result.get(1));
+        assertEquals(3, result.get(2));
+    }
+
+    @Test
+    public void getCollectionOfLongPrimitiveValuesFromForm() {
+        final String testFormData = "vals=100&vals=200";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        final List<Long> result = node.getCollectionOfPrimitiveValues(Long.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals(100L, result.get(0));
+        assertEquals(200L, result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfDoublePrimitiveValuesFromForm() {
+        final String testFormData = "vals=1.5&vals=2.5";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        final List<Double> result = node.getCollectionOfPrimitiveValues(Double.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals(1.5, result.get(0));
+        assertEquals(2.5, result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfFloatPrimitiveValuesFromForm() {
+        final String testFormData = "vals=1.5&vals=2.5";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        final List<Float> result = node.getCollectionOfPrimitiveValues(Float.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals(1.5f, result.get(0));
+        assertEquals(2.5f, result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfShortPrimitiveValuesFromForm() {
+        final String testFormData = "vals=10&vals=20";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        final List<Short> result = node.getCollectionOfPrimitiveValues(Short.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals((short) 10, result.get(0));
+        assertEquals((short) 20, result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfBytePrimitiveValuesFromForm() {
+        final String testFormData = "vals=1&vals=2";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        final List<Byte> result = node.getCollectionOfPrimitiveValues(Byte.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals((byte) 1, result.get(0));
+        assertEquals((byte) 2, result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfBigDecimalPrimitiveValuesFromForm() {
+        final String testFormData = "vals=123.45&vals=678.90";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        final List<BigDecimal> result = node.getCollectionOfPrimitiveValues(BigDecimal.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals(new BigDecimal("123.45"), result.get(0));
+        assertEquals(new BigDecimal("678.90"), result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfOffsetDateTimePrimitiveValuesFromForm() {
+        final String dt1 = "2024-01-01T00:00:00Z";
+        final String dt2 = "2024-06-15T12:30:00Z";
+        final String testFormData =
+                "vals="
+                        + URLEncoder.encode(dt1, StandardCharsets.UTF_8)
+                        + "&vals="
+                        + URLEncoder.encode(dt2, StandardCharsets.UTF_8);
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        final List<OffsetDateTime> result =
+                node.getCollectionOfPrimitiveValues(OffsetDateTime.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals(OffsetDateTime.parse(dt1), result.get(0));
+        assertEquals(OffsetDateTime.parse(dt2), result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfLocalDatePrimitiveValuesFromForm() {
+        final String testFormData = "vals=2024-01-01&vals=2024-06-15";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        final List<LocalDate> result = node.getCollectionOfPrimitiveValues(LocalDate.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals(LocalDate.parse("2024-01-01"), result.get(0));
+        assertEquals(LocalDate.parse("2024-06-15"), result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfLocalTimePrimitiveValuesFromForm() {
+        final String testFormData = "vals=08:00:00&vals=17:30:00";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        final List<LocalTime> result = node.getCollectionOfPrimitiveValues(LocalTime.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals(LocalTime.of(8, 0, 0), result.get(0));
+        assertEquals(LocalTime.of(17, 30, 0), result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfPeriodAndDurationPrimitiveValuesFromForm() {
+        final String testFormData = "vals=P1M&vals=PT2H";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        final List<PeriodAndDuration> result =
+                node.getCollectionOfPrimitiveValues(PeriodAndDuration.class);
+        assertNotNull(result);
+        assertEquals(2, result.size());
+        assertEquals(PeriodAndDuration.parse("P1M"), result.get(0));
+        assertEquals(PeriodAndDuration.parse("PT2H"), result.get(1));
+    }
+
+    @Test
+    public void getCollectionOfPrimitiveValuesThrowsForUnknownType() {
+        final String testFormData = "vals=foo";
+        final ParseNode node = new FormParseNode(testFormData).getChildNode("vals");
+        assertThrows(
+                RuntimeException.class, () -> node.getCollectionOfPrimitiveValues(Object.class));
+    }
 }