Merge pull request #2139 from microsoft/dependabot/gradle/com.github.spotbugs-6.5.9

chore(deps): bump com.github.spotbugs from 6.5.8 to 6.5.9

Author: github-actions[bot]

components/abstractions/src/test/java/com/microsoft/kiota/MultiPartBodyTest.java

@@ -12,21 +12,25 @@
 import org.junit.jupiter.api.Test;
 
 class MultiPartBodyTest {
+    private static <T> T nullValue() {
+        return java.util.Collections.<String, T>emptyMap().get("missing");
+    }
+
     @Test
     void defensive() {
         final MultipartBody multipartBody = new MultipartBody();
         assertThrows(
                 IllegalArgumentException.class,
-                () -> multipartBody.addOrReplacePart(null, "foo", "bar"));
+                () -> multipartBody.addOrReplacePart(nullValue(), "foo", "bar"));
         assertThrows(
                 IllegalArgumentException.class,
-                () -> multipartBody.addOrReplacePart("foo", null, "bar"));
+                () -> multipartBody.addOrReplacePart("foo", nullValue(), "bar"));
         assertThrows(
                 NullPointerException.class,
-                () -> multipartBody.addOrReplacePart("foo", "bar", null));
-        assertThrows(IllegalArgumentException.class, () -> multipartBody.getPartValue(null));
-        assertThrows(IllegalArgumentException.class, () -> multipartBody.removePart(null));
-        assertThrows(NullPointerException.class, () -> multipartBody.serialize(null));
+                () -> multipartBody.addOrReplacePart("foo", "bar", nullValue()));
+        assertThrows(IllegalArgumentException.class, () -> multipartBody.getPartValue(nullValue()));
+        assertThrows(IllegalArgumentException.class, () -> multipartBody.removePart(nullValue()));
+        assertThrows(NullPointerException.class, () -> multipartBody.serialize(nullValue()));
         assertThrows(
                 UnsupportedOperationException.class, () -> multipartBody.getFieldDeserializers());
     }

components/abstractions/src/test/java/com/microsoft/kiota/PeriodAndDurationTest.java

@@ -10,30 +10,40 @@
 import java.time.temporal.ChronoUnit;
 
 class PeriodAndDurationTest {
+    private static <T> T nullValue() {
+        return java.util.Collections.<String, T>emptyMap().get("missing");
+    }
+
     @Test
     void Defensive() {
         // Assert
         var exception =
-                assertThrows(NullPointerException.class, () -> PeriodAndDuration.of(null, null));
+                assertThrows(
+                        NullPointerException.class,
+                        () -> PeriodAndDuration.of(nullValue(), nullValue()));
         assertTrue(exception.getMessage().contains("period cannot be null"));
 
         var exception2 =
                 assertThrows(
                         NullPointerException.class,
-                        () -> PeriodAndDuration.of(null, Duration.ZERO));
+                        () -> PeriodAndDuration.of(nullValue(), Duration.ZERO));
         assertTrue(exception2.getMessage().contains("period cannot be null"));
 
         var exception3 =
                 assertThrows(
-                        NullPointerException.class, () -> PeriodAndDuration.of(Period.ZERO, null));
+                        NullPointerException.class,
+                        () -> PeriodAndDuration.of(Period.ZERO, nullValue()));
         assertTrue(exception3.getMessage().contains("duration cannot be null"));
 
         var exception4 =
-                assertThrows(NullPointerException.class, () -> PeriodAndDuration.ofDuration(null));
+                assertThrows(
+                        NullPointerException.class,
+                        () -> PeriodAndDuration.ofDuration(nullValue()));
         assertTrue(exception4.getMessage().contains("duration cannot be null"));
 
         var exception5 =
-                assertThrows(NullPointerException.class, () -> PeriodAndDuration.ofPeriod(null));
+                assertThrows(
+                        NullPointerException.class, () -> PeriodAndDuration.ofPeriod(nullValue()));
         assertTrue(exception5.getMessage().contains("period cannot be null"));
 
         final PeriodAndDuration periodAndDuration =

components/abstractions/src/test/java/com/microsoft/kiota/authentication/ApiKeyAuthenticationProviderTest.java

@@ -10,6 +10,10 @@
 import java.util.HashSet;
 
 public class ApiKeyAuthenticationProviderTest {
+    private static <T> T nullValue() {
+        return java.util.Collections.<String, T>emptyMap().get("missing");
+    }
+
     @Test
     void DefensivePrograming() {
         assertThrows(
@@ -23,7 +27,9 @@ void DefensivePrograming() {
 
         var value =
                 new ApiKeyAuthenticationProvider("key", "param", ApiKeyLocation.QUERY_PARAMETER);
-        assertThrows(NullPointerException.class, () -> value.authenticateRequest(null, null));
+        assertThrows(
+                NullPointerException.class,
+                () -> value.authenticateRequest(nullValue(), nullValue()));
     }
 
     @Test

components/abstractions/src/test/java/com/microsoft/kiota/serialization/DeserializationHelpersTest.java

@@ -19,29 +19,45 @@ class DeserializationHelpersTest {
     private static final String _jsonContentType = "application/json";
     private static final String _charset = "utf-8";
 
+    private static <T> T nullValue() {
+        return java.util.Collections.<String, T>emptyMap().get("missing");
+    }
+
+    private static String nullString() {
+        return nullValue();
+    }
+
+    private static InputStream nullInputStream() {
+        return nullValue();
+    }
+
+    private static ParsableFactory<TestEntity> nullFactory() {
+        return nullValue();
+    }
+
     @Test
     void defensive() {
         assertThrows(
                 NullPointerException.class,
                 () ->
                         KiotaSerialization.deserialize(
-                                null,
-                                (InputStream) null,
+                                nullString(),
+                                nullInputStream(),
                                 TestEntity::createFromDiscriminatorValue));
         assertThrows(
                 NullPointerException.class,
                 () ->
                         KiotaSerialization.deserialize(
                                 _jsonContentType,
-                                (InputStream) null,
+                                nullInputStream(),
                                 TestEntity::createFromDiscriminatorValue));
         assertThrows(
                 NullPointerException.class,
                 () ->
                         KiotaSerialization.deserialize(
                                 _jsonContentType,
                                 new ByteArrayInputStream("{}".getBytes(_charset)),
-                                (ParsableFactory<TestEntity>) null));
+                                nullFactory()));
     }
 
     @Test
@@ -50,23 +66,23 @@ void defensiveCollection() {
                 NullPointerException.class,
                 () ->
                         KiotaSerialization.deserializeCollection(
-                                null,
-                                (InputStream) null,
+                                nullString(),
+                                nullInputStream(),
                                 TestEntity::createFromDiscriminatorValue));
         assertThrows(
                 NullPointerException.class,
                 () ->
                         KiotaSerialization.deserializeCollection(
                                 _jsonContentType,
-                                (InputStream) null,
+                                nullInputStream(),
                                 TestEntity::createFromDiscriminatorValue));
         assertThrows(
                 NullPointerException.class,
                 () ->
                         KiotaSerialization.deserializeCollection(
                                 _jsonContentType,
                                 new ByteArrayInputStream("{}".getBytes(_charset)),
-                                (ParsableFactory<TestEntity>) null));
+                                nullFactory()));
     }
 
     @Test

components/abstractions/src/test/java/com/microsoft/kiota/serialization/SerializationHelpersTest.java

@@ -25,26 +25,42 @@ class SerializationHelpersTest {
     private static final String _jsonContentType = "application/json";
     private static final String _charset = "utf-8";
 
+    private static <T> T nullValue() {
+        return java.util.Collections.<String, T>emptyMap().get("missing");
+    }
+
+    private static String nullString() {
+        return nullValue();
+    }
+
+    private static Parsable nullParsable() {
+        return nullValue();
+    }
+
+    private static Iterable<Parsable> nullParsableCollection() {
+        return nullValue();
+    }
+
     @Test
     void defensive() {
         assertThrows(
                 NullPointerException.class,
-                () -> KiotaSerialization.serializeAsStream(null, (Parsable) null));
+                () -> KiotaSerialization.serializeAsStream(nullString(), nullParsable()));
         assertThrows(
                 NullPointerException.class,
-                () -> KiotaSerialization.serializeAsStream(_jsonContentType, (Parsable) null));
+                () -> KiotaSerialization.serializeAsStream(_jsonContentType, nullParsable()));
     }
 
     @Test
     void defensiveCollection() {
         assertThrows(
                 NullPointerException.class,
-                () -> KiotaSerialization.serializeAsStream(null, (Iterable<Parsable>) null));
+                () -> KiotaSerialization.serializeAsStream(nullString(), nullParsableCollection()));
         assertThrows(
                 NullPointerException.class,
                 () ->
                         KiotaSerialization.serializeAsStream(
-                                _jsonContentType, (Iterable<Parsable>) null));
+                                _jsonContentType, nullParsableCollection()));
     }
 
     @Test

components/abstractions/src/test/java/com/microsoft/kiota/serialization/mocks/TestBackedModelEntity.java

@@ -104,7 +104,10 @@ public Map<String, Consumer<ParseNode>> getFieldDeserializers() {
                 put(
                         "workDuration",
                         n -> {
-                            setWorkDuration(n.getPeriodAndDurationValue());
+                            final var value = n.getPeriodAndDurationValue();
+                            if (value != null) {
+                                setWorkDuration(value);
+                            }
                         });
                 put(
                         "startWorkTime",

components/abstractions/src/test/java/com/microsoft/kiota/serialization/mocks/TestEntity.java

@@ -110,7 +110,10 @@ public Map<String, Consumer<ParseNode>> getFieldDeserializers() {
                 put(
                         "workDuration",
                         (n) -> {
-                            setWorkDuration(n.getPeriodAndDurationValue());
+                            final var value = n.getPeriodAndDurationValue();
+                            if (value != null) {
+                                setWorkDuration(value);
+                            }
                         });
                 put(
                         "startWorkTime",

components/bundle/src/test/java/com/microsoft/kiota/bundle/BundleTests.java

@@ -10,10 +10,15 @@
 import org.junit.jupiter.api.Test;
 
 class BundleTests {
+    private static <T> T nullValue() {
+        return java.util.Collections.<String, T>emptyMap().get("missing");
+    }
+
     @Test
     void throwsErrorNullAuthenticationProvider() throws Exception {
         var exception =
-                assertThrows(NullPointerException.class, () -> new DefaultRequestAdapter(null));
+                assertThrows(
+                        NullPointerException.class, () -> new DefaultRequestAdapter(nullValue()));
         assertEquals("parameter authenticationProvider cannot be null", exception.getMessage());
     }
 

components/http/okHttp/gradle/dependencies.gradle

@@ -6,6 +6,7 @@ dependencies {
     testImplementation(libs.org.mockito.mockito.core)
     testImplementation(libs.com.squareup.okhttp3.logging.interceptor)
     testImplementation(libs.com.squareup.okhttp3.mockwebserver)
+    testImplementation(libs.io.github.std.uritemplate.std.uritemplate)
 
 
     // This dependency is used internally, and not exposed to consumers on their own compile classpath.

components/http/okHttp/src/test/java/com/microsoft/kiota/http/OkHttpRequestAdapterTest.java

@@ -51,6 +51,10 @@
 import java.util.stream.Stream;
 
 public class OkHttpRequestAdapterTest {
+    private static <T> T nullValue() {
+        return java.util.Collections.<String, T>emptyMap().get("missing");
+    }
+
     @ParameterizedTest
     @EnumSource(
             value = HttpMethod.class,
@@ -618,7 +622,7 @@ public static OkHttpClient getMockClient(final Response response) throws IOExcep
                         (Answer<Void>)
                                 invocation -> {
                                     Callback callback = invocation.getArgument(0);
-                                    callback.onResponse(null, response);
+                                    callback.onResponse(nullValue(), response);
                                     return null;
                                 })
                 .when(remoteCall)