Skip to content

Commit cb80089

Browse files
author
Johnson George
committed
mcp: pin isort classification to fix CI flake8
Local (lisa_mcp editable-installed) and CI (no install) classified lisa_mcp into different isort groups, flipping I003/I004 between environments. Pin known_first_party/known_third_party so grouping is deterministic, and re-run isort on the 4 affected files.
1 parent a922cb2 commit cb80089

5 files changed

Lines changed: 15 additions & 6 deletions

File tree

mcp/lisa_mcp/server.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,13 @@
66
import argparse
77
import logging
88

9+
from mcp.server.fastmcp import FastMCP
10+
911
from lisa_mcp.tools.execution import register_execution_tools
1012
from lisa_mcp.tools.knowledge import register_knowledge_tools
1113
from lisa_mcp.tools.log_analysis import register_log_analysis_tools
1214
from lisa_mcp.tools.runbook import register_runbook_tools
1315
from lisa_mcp.tools.test_writer import register_test_writer_tools
14-
from mcp.server.fastmcp import FastMCP
1516

1617
logging.basicConfig(level=logging.INFO)
1718
log = logging.getLogger("lisa-mcp")
@@ -88,13 +89,12 @@ def main() -> None:
8889
import os
8990

9091
import uvicorn
92+
from mcp.server.sse import SseServerTransport
9193
from starlette.applications import Starlette
9294
from starlette.middleware import Middleware
9395
from starlette.middleware.trustedhost import TrustedHostMiddleware
9496
from starlette.routing import Mount, Route
9597

96-
from mcp.server.sse import SseServerTransport
97-
9898
sse = SseServerTransport("/messages/")
9999

100100
async def handle_sse(request):

mcp/lisa_mcp/tools/knowledge.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,14 @@
88
import re
99
from pathlib import Path
1010

11+
from mcp.server.fastmcp import FastMCP
12+
1113
from lisa_mcp.tools._repo import (
1214
find_repo_root,
1315
load_context_file,
1416
load_doc_for_topic,
1517
load_docs_for_tool,
1618
)
17-
from mcp.server.fastmcp import FastMCP
1819

1920

2021
def register_knowledge_tools(mcp: FastMCP) -> None: # noqa: C901

mcp/lisa_mcp/tools/log_analysis.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,10 @@
1616
from urllib.parse import unquote, urlparse
1717
from urllib.request import Request, urlopen
1818

19-
from lisa_mcp.tools._repo import find_repo_root, load_context_file, load_docs_for_tool
2019
from mcp.server.fastmcp import FastMCP
2120

21+
from lisa_mcp.tools._repo import find_repo_root, load_context_file, load_docs_for_tool
22+
2223

2324
def _load_ai_prompts() -> str:
2425
"""Load the LISA AI log analyzer prompts from lisa/ai/prompts/default/.

mcp/lisa_mcp/tools/test_writer.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@
1111
from pathlib import Path
1212
from typing import Optional
1313

14-
from lisa_mcp.tools._repo import find_repo_root, load_test_writer_prompt
1514
from mcp.server.fastmcp import FastMCP
1615

16+
from lisa_mcp.tools._repo import find_repo_root, load_test_writer_prompt
17+
1718

1819
def register_test_writer_tools(mcp: FastMCP) -> None: # noqa: C901
1920
@mcp.tool()

pyproject.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,12 @@ use_parentheses = true
193193
ensure_newline_before_comments = true
194194
line_length = 88
195195
extend_skip_glob = [".nox/*", ".venv*/*"]
196+
# Pin classification so local (editable-installed `lisa_mcp`) and CI
197+
# (no install) agree on import grouping. Without this, isort treats
198+
# `lisa_mcp` as first-party locally but third-party in CI, which
199+
# flips I003/I004 between environments.
200+
known_first_party = ["lisa", "lisa_mcp"]
201+
known_third_party = ["mcp"]
196202

197203

198204
[tool.mypy]

0 commit comments

Comments
 (0)