Fix MSHV install guest path handling#4510
Merged
johnsongeorge-w merged 1 commit intoJun 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates remote path handling in the MSHV install suite to be OS-agnostic on the controller side by switching from Path to POSIX-only pure paths.
Changes:
- Use
PurePosixPathfor constant remote file paths (e.g.,/home/cloud/...,/boot/efi/...). - Update
_get_file_md5()to accept aPurePathinstead ofPath.
vyadavmsft
approved these changes
Jun 1, 2026
johnsongeorge-w
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Installing the Microsoft hypervisor on a guest doesn't work when the host is Windows. The reason is that the path concatenation APIs use Windows path semantics and misinterpret the POSIX paths.
The fix is to use
PurePosixPath.Related Issue
Type of Change
Checklist
Test Validation
With this fix, I can run the LISA tests that are part of our automated nightly testing.
Key Test Cases:
verify_mshv_install_succeeds
Impacted LISA Features:
MshvHostInstallSuite
Tested Azure Marketplace Images:
N/A - local Azure Linux Dom0 VHD booted via Hyper-V
Test Results