Skip to content

Fix MSHV install guest path handling#4510

Merged
johnsongeorge-w merged 1 commit into
microsoft:mainfrom
pbarbuda:pbarbuda/mshv-posix-guest-paths
Jun 2, 2026
Merged

Fix MSHV install guest path handling#4510
johnsongeorge-w merged 1 commit into
microsoft:mainfrom
pbarbuda:pbarbuda/mshv-posix-guest-paths

Conversation

@pbarbuda
Copy link
Copy Markdown
Contributor

@pbarbuda pbarbuda commented Jun 1, 2026

Description

Installing the Microsoft hypervisor on a guest doesn't work when the host is Windows. The reason is that the path concatenation APIs use Windows path semantics and misinterpret the POSIX paths.

The fix is to use PurePosixPath.

Related Issue

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation update

Checklist

  • Description is filled in above
  • No credentials, secrets, or internal details are included
  • Peer review requested (if not, add required peer reviewers after raising PR)
  • Tests executed and results posted below

Test Validation

With this fix, I can run the LISA tests that are part of our automated nightly testing.

Key Test Cases:
verify_mshv_install_succeeds

Impacted LISA Features:
MshvHostInstallSuite

Tested Azure Marketplace Images:
N/A - local Azure Linux Dom0 VHD booted via Hyper-V

Test Results

Image VM Size Result
Azure Linux Dom0 VHD, 3.0.20260517, kernel 6.6.121.mshv3-1000.gaf140a66.lv3 Local Hyper-V VM, 2 vCPU / 1 GB PASSED

Copilot AI review requested due to automatic review settings June 1, 2026 15:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates remote path handling in the MSHV install suite to be OS-agnostic on the controller side by switching from Path to POSIX-only pure paths.

Changes:

  • Use PurePosixPath for constant remote file paths (e.g., /home/cloud/..., /boot/efi/...).
  • Update _get_file_md5() to accept a PurePath instead of Path.

Comment thread lisa/microsoft/testsuites/mshv/mshv_install.py
Comment thread lisa/microsoft/testsuites/mshv/mshv_install.py
@vyadavmsft vyadavmsft self-requested a review June 1, 2026 22:36
@johnsongeorge-w johnsongeorge-w merged commit 5385e90 into microsoft:main Jun 2, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants