[AI Generated] BugFix: default raw VHD image source to x64 architecture#4559
Closed
rabdulfaizy wants to merge 1 commit into
Closed
[AI Generated] BugFix: default raw VHD image source to x64 architecture#4559rabdulfaizy wants to merge 1 commit into
rabdulfaizy wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Azure raw VHD deployments selecting ARM64-only SKUs by defaulting VhdSchema.architecture to x64 when it’s not explicitly set, ensuring the Azure Architecture feature generates an x64-only requirement for VHD image sources.
Changes:
- Default
VhdSchema.architecturetoschema.ArchitectureType.x64when unset inload_from_platform(). - Preserve user override behavior when
architectureis explicitly provided in the runbook.
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-arm64 latest
Test case details
|
Member
Author
|
Closing as duplicate - the bug was independently fixed by another contributor. No change needed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default
VhdSchema.architecturetox64when not explicitly set, so LISA'sArchitecturefeature produces an x64-only requirement for raw VHD image sources. Without this default,Architecture.create_image_requirement()returnsNonefor VHDs, allowing ARM64 SKUs (e.g.Standard_D2pds_v6) to be picked for x64-only VHD blobs and causing deployment failures such as:Azure does not deploy raw VHD blobs to ARM64 VMs, so x64 is the safe and correct default. Users with ARM64 VHDs can still override via
vhd.architecture: Arm64in their runbook.Change
3 lines added to
VhdSchema.load_from_platform()inlisa/sut_orchestrator/azure/common.py:Validation
Standard_D2pds_v6(Arm64) → deployment fails with architecture mismatch.Standard_D2ads_v5(x64) → deployed in 94s, smoke_testPASSEDin 86s.pylint: 10/10 on changed lines.Closes-ADO-Bug: 62695399