fix: propagate zip converter options to nested files#2143
Closed
zaidazmi wants to merge 1 commit into
Closed
Conversation
|
@zaidazmi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Propagates keyword options from
ZipConverter.convert()into nestedconvert_stream()calls for files inside archives. This preserves per-call options such askeep_data_uris=Truewhen the converted file is inside a.zip.This is complementary to #1977, which discusses storing/injecting
keep_data_urisas a global option; this PR covers kwargs supplied on the ZIP conversion call itself.Validation
uv run --project packages/markitdown --extra all --with pytest python -m pytest packages/markitdown/tests/test_module_misc.py -k zip_conversion_propagates_keep_data_uris