feat: add GIF support to ImageConverter#2213
Open
UditDewan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1103
ImageConverterrejected GIF files withUnsupportedFormatException, even though exiftool (used for metadata extraction) and multimodal LLM APIs both handle GIFs. As noted by @afourney in the issue, there's no reason not to support them.Changes
image/giftoACCEPTED_MIME_TYPE_PREFIXESand.giftoACCEPTED_FILE_EXTENSIONSin_image_converter.py. The existing metadata and LLM-captioning code paths work unchanged:mimetypes.guess_typealready resolves.gifcorrectly, so the data URI sent to the LLM gets the properimage/gifcontent type.tests/test_files/test.gif(a 43-byte 1x1 GIF) andtest_markitdown_gif_imageintest_module_misc.py, which verifies a GIF converts without raising and that the image is sent to the LLM client as adata:image/gif;base64,URI.Testing
test_module_misc.pyandtest_module_vectors.pylocal-file suites.