Fix typos in 03-GettingStarted/14-sampling README.md#690
Merged
leestott merged 4 commits intoApr 11, 2026
Conversation
marietta-a
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the sampling lesson documentation by correcting several typos/grammar issues in 03-GettingStarted/14-sampling/README.md.
Changes:
- Fixes wording/grammar in the sampling request explanation (e.g., “personality”, “are recommended”).
- Fixes duplicated word in a note and improves grammar in a numbered list.
- Adjusts assignment section wording (“arguments”, “to construct”).
Show a summary per file
| File | Description |
|---|---|
| 03-GettingStarted/14-sampling/README.md | Documentation typo/grammar fixes in the sampling lesson README. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
Comment on lines
+335
to
+337
| **Scenario**: The back office worker at an e-commerce needs help, it takes way too much time to generate product descriptions. Therefore, you are to build a solution where you can call a tool "create_product" with "title" and "keywords" as arguments and it should produce a complete product including a "description" field that should be populated by a client's LLM. | ||
|
|
||
| TIP: use what you learned earlier how to construct this server and its tool using a sampling request. | ||
| TIP: use what you learned earlier to construct this server and its tool using a sampling request. |
There was a problem hiding this comment.
PR description says this fixes typos in this README, but there are still obvious typos earlier in the same file (e.g., “Sampling is an davanced features…” around line 21). Either broaden the PR to include those remaining typos or adjust the PR description/scope accordingly.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
marietta-a
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes typos in 03-GettingStarted/14-sampling README.md, such as:
"...gives your LLM a personaly ..." -> "... gives your LLM a personality ..."
"... if you're only building building a server ..." -> "... if you're only building a server ..."