[Part 1] Move tests to unified project design#2641
Open
alzimmermsft wants to merge 1 commit into
Open
Conversation
jongio
reviewed
May 16, 2026
Contributor
jongio
left a comment
There was a problem hiding this comment.
The consolidation approach looks right and follows the pattern Azure.Mcp.Core.Tests already established. One thing to address before this lands:
The renamed *.Tests.csproj files don't have HasLiveTests or HasUnitTests MSBuild properties. Test-Code.ps1 (line 52-55) and New-BuildInfo.ps1 (line 344-354) both rely on these properties when the project name matches *Tests.csproj instead of the old *UnitTests.csproj/*LiveTests.csproj patterns. Without them, these projects get silently excluded from test discovery - both locally and in the CI test matrix.
The already-migrated Azure.Mcp.Core.Tests.csproj sets both properties:
<HasLiveTests>true</HasLiveTests>
<HasUnitTests>true</HasUnitTests>Each renamed project here needs the same treatment:
- ACR Tests:
HasLiveTests=true+HasUnitTests=true(merges both) - Server Tests, Fabric Server Tests, Advisor Tests:
HasUnitTests=true(unit-only)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves tests to unified project design, where there is a single
*.Testsprojects instead of separate*.LiveTestsand*.UnitTestsprojects. This is possible as live tests are now recorded using Test Proxy and no longer require Azure resources to be deployed to run, using session records when running in CI.GitHub issue number?
[Link to the GitHub issue this PR addresses]Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline