Skip to content

[Part 1] Move tests to unified project design#2641

Open
alzimmermsft wants to merge 1 commit into
microsoft:mainfrom
alzimmermsft:MoveMoreTestsToNewDesign
Open

[Part 1] Move tests to unified project design#2641
alzimmermsft wants to merge 1 commit into
microsoft:mainfrom
alzimmermsft:MoveMoreTestsToNewDesign

Conversation

@alzimmermsft
Copy link
Copy Markdown
Contributor

What does this PR do?

Moves tests to unified project design, where there is a single *.Tests projects instead of separate *.LiveTests and *.UnitTests projects. This is possible as live tests are now recorded using Test Proxy and no longer require Azure resources to be deployed to run, using session records when running in CI.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Copy Markdown
Contributor

@jongio jongio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consolidation approach looks right and follows the pattern Azure.Mcp.Core.Tests already established. One thing to address before this lands:

The renamed *.Tests.csproj files don't have HasLiveTests or HasUnitTests MSBuild properties. Test-Code.ps1 (line 52-55) and New-BuildInfo.ps1 (line 344-354) both rely on these properties when the project name matches *Tests.csproj instead of the old *UnitTests.csproj/*LiveTests.csproj patterns. Without them, these projects get silently excluded from test discovery - both locally and in the CI test matrix.

The already-migrated Azure.Mcp.Core.Tests.csproj sets both properties:

<HasLiveTests>true</HasLiveTests>
<HasUnitTests>true</HasUnitTests>

Each renamed project here needs the same treatment:

  • ACR Tests: HasLiveTests=true + HasUnitTests=true (merges both)
  • Server Tests, Fabric Server Tests, Advisor Tests: HasUnitTests=true (unit-only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants