Reliable reset: plumb FinalSize and enforce reset-equivalent flow-control accounting#6024
Open
gaurav2699 wants to merge 6 commits into
Open
Reliable reset: plumb FinalSize and enforce reset-equivalent flow-control accounting#6024gaurav2699 wants to merge 6 commits into
gaurav2699 wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6024 +/- ##
==========================================
+ Coverage 85.03% 85.37% +0.34%
==========================================
Files 60 60
Lines 18792 18816 +24
==========================================
+ Hits 15980 16065 +85
+ Misses 2812 2751 -61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
guhetier
requested changes
May 21, 2026
guhetier
left a comment
guhetier
left a comment
Collaborator
There was a problem hiding this comment.
Except for the FinalSize < ReliableOffset check, I don't understand what this change tries to achieve.
guhetier
reviewed
May 21, 2026
| BOOLEAN CloseNow = Stream->RecvBuffer.BaseOffset >= ReliableOffset; | ||
|
|
||
| if (!Stream->Flags.RemoteCloseResetReliable && CloseNow) { | ||
| uint64_t TotalRecvLength = QuicRecvBufferGetTotalLength(&Stream->RecvBuffer); |
Collaborator
There was a problem hiding this comment.
Are you looking for Stream->RecvMaxLength?
| // as a result. | ||
| // | ||
| uint64_t FlowControlIncrease = FinalSize - TotalReadLength; | ||
| Stream->Connection->Send.MaxData += FlowControlIncrease; |
Collaborator
There was a problem hiding this comment.
I don't think we have a reason to give flow control here. More flow control will be granted as we receive bytes.
Contributor
|
What issue is this PR resolving? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds FinalSize to QuicStreamProcessReliableResetFrame and updates RELIABLE_RESET dispatch to pass Frame.FinalSize.
Mirrors QuicStreamProcessResetFrame accounting in reliable reset handling:
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?