Revert "Bring network wire schema to full GA spec" (PR676) - #707
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
MGudgin
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the incomplete GA network schema migration, restoring the legacy network contract and associated test coverage.
Changes:
- Restores legacy network and proxy models, parser behavior, generated schema, and SDK types.
- Restores legacy networking fixtures across supported backends.
- Re-enables previously deferred tests and SDK integration testing.
Show a summary per file
| File | Description |
|---|---|
tests/examples/wslc_hello_world.json |
Restores legacy default-deny policy. |
tests/examples/27_mac_terminal_sandboxed.json |
Restores legacy default-deny policy. |
tests/examples/25_mac_ui_clipboard_enabled.json |
Restores legacy default-deny policy. |
tests/examples/24_mac_ui_disabled.json |
Restores legacy default-deny policy. |
tests/examples/23_mac_blocked_hosts_unsupported.json |
Restores legacy blocked-host example. |
tests/examples/22_mac_network_allow_all.json |
Restores legacy allow-all policy. |
tests/examples/21_mac_python_info.json |
Restores legacy default-deny policy. |
tests/examples/20_mac_combined_restrictions.json |
Restores hostname allowlist. |
tests/examples/19_mac_network_restricted.json |
Restores hostname allowlist. |
tests/examples/18_mac_filesystem_access.json |
Restores legacy default-deny policy. |
tests/examples/17_mac_deny_filesystem.json |
Restores legacy default-deny policy. |
tests/examples/16_mac_deny_network.json |
Restores legacy default-deny policy. |
tests/examples/15_mac_hello_world.json |
Restores legacy default-deny policy. |
tests/examples/13_lxc_network_restricted.json |
Restores LXC firewall configuration. |
tests/examples/12_builtin_test_proxy_processcontainer.json |
Restores built-in proxy configuration. |
tests/examples/11_localhost_proxy_processcontainer.json |
Restores localhost proxy configuration. |
tests/examples/06_network_capabilities_only.json |
Restores capability enforcement settings. |
tests/examples/04_combined_restrictions.json |
Restores combined network restrictions. |
tests/examples/03_network_restricted.json |
Restores firewall host filtering. |
tests/configs/wslc_timeout.json |
Restores legacy default-deny policy. |
tests/configs/wslc_tar_import_rootfs.json |
Restores legacy default-deny policy. |
tests/configs/wslc_tar_import_docker_save.json |
Restores legacy default-deny policy. |
tests/configs/wslc_stderr.json |
Restores legacy default-deny policy. |
tests/configs/wslc_readonly_mount.json |
Restores legacy default-deny policy. |
tests/configs/wslc_python_stdlib.json |
Restores legacy default-deny policy. |
tests/configs/wslc_python_hello.json |
Restores legacy default-deny policy. |
tests/configs/wslc_port_mapping_tcp.json |
Restores allow-all policy. |
tests/configs/wslc_port_mapping_multiple.json |
Restores allow-all policy. |
tests/configs/wslc_network_isolated.json |
Restores legacy default-deny policy. |
tests/configs/wslc_most_specific_denied_parent.json |
Restores allow-all policy. |
tests/configs/wslc_large_output.json |
Restores legacy default-deny policy. |
tests/configs/wslc_filesystem.json |
Restores allow-all policy. |
tests/configs/wslc_filesystem_object.json |
Restores allow-all policy. |
tests/configs/wslc_exit_code.json |
Restores legacy default-deny policy. |
tests/configs/wslc_env_vars.json |
Restores legacy default-deny policy. |
tests/configs/wslc_destroy_on_exit_true.json |
Restores legacy default-deny policy. |
tests/configs/wslc_destroy_on_exit_false.json |
Restores legacy default-deny policy. |
tests/configs/wslc_denied_masking.json |
Restores allow-all policy. |
tests/configs/wslc_denied_dotdot_alias.json |
Restores allow-all policy. |
tests/configs/wslc_custom_registry.json |
Restores allow-all policy. |
tests/configs/wslc_custom_registry_quay.json |
Restores allow-all policy. |
tests/configs/wslc_custom_registry_ghcr.json |
Restores allow-all policy. |
tests/configs/proxy_builtin_test.json |
Restores built-in proxy configuration. |
tests/configs/processcontainer_network_unc_blocked.json |
Restores capability-based blocking. |
tests/configs/processcontainer_network_tcp_blocked.json |
Restores capability-based blocking. |
tests/configs/processcontainer_network_icmp_blocked.json |
Restores capability-based blocking. |
tests/configs/processcontainer_network_dns_blocked.json |
Restores capability-based blocking. |
tests/configs/network_firewall_test.json |
Restores firewall host filtering. |
tests/configs/network_default_test.json |
Restores default host filtering. |
tests/configs/network_capabilities_test.json |
Restores capability host filtering. |
tests/configs/network_both_test.json |
Restores combined enforcement. |
tests/configs/microvm_network.json |
Restores legacy allow-all policy. |
tests/configs/microvm_network_linux.json |
Restores legacy allow-all policy. |
tests/configs/lxc_network_test.json |
Restores LXC host rules. |
tests/configs/hyperlight_networking.json |
Restores Hyperlight allowlist. |
tests/configs/hyperlight_networking_blocked.json |
Restores Hyperlight allowlist. |
tests/configs/bubblewrap_network_proxy_builtin.json |
Restores Bubblewrap built-in proxy. |
tests/configs/bubblewrap_network_proxy_blocklist.json |
Restores proxy blocklist. |
tests/configs/bubblewrap_network_proxy_allowlist.json |
Restores proxy allowlist. |
tests/configs/bubblewrap_network_firewall.json |
Restores firewall host rules. |
tests/configs/bubblewrap_network_block.json |
Restores default-deny policy. |
src/testing/wxc_e2e_tests/tests/e2e_windows.rs |
Re-enables networking E2E cases. |
src/testing/wxc_e2e_tests/tests/e2e_seatbelt_characterization.rs |
Re-enables Seatbelt proxy test. |
src/core/wxc_common/src/wire.rs |
Restores legacy wire network model. |
src/core/wxc_common/src/models.rs |
Removes unused GA egress models. |
src/core/wxc_common/src/config_parser.rs |
Restores legacy network parsing and tests. |
src/core/mxc_engine/src/policy.rs |
Re-enables policy tests. |
src/core/mxc_engine/src/dispatch.rs |
Re-enables dispatch tests. |
sdk/node/tests/unit/wire-conformance.test.ts |
Restores legacy conformance assertions. |
sdk/node/src/generated/wire.ts |
Regenerates legacy wire types. |
schemas/dev/mxc-config.schema.0.8.0-dev.json |
Restores legacy generated schema. |
.github/workflows/SDK.Integration.Test.Job.yml |
Re-enables SDK integration tests. |
Review details
- Files reviewed: 71/72 changed files
- Comments generated: 2
- Review effort level: Medium
bbonaby
approved these changes
Jul 29, 2026
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit dd14f80 (PR #676)
Microsoft Reviewers: Open in CodeFlow